-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add option to pass in rpc client when using anchor_client #3053
feat: Add option to pass in rpc client when using anchor_client #3053
Conversation
@cryptopapi997 is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not directly accept mocks (similar to new_mock_with_mocks
), with a new feature called mock
? I feel like this would be easier to discover and use.
I feel like the way it's currently is more general, which in this case is a good thing because it means if the solana mock doesn't support a specific kind of operation anyone can spin up their own adapted mock version and pass it in. The docs for
Happy to rename the feature to |
wdyt @acheroncrypto ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to rename the feature to
mock
though if you think that's more clear.
Yeah, I think it's more clear.
Also, we might have to merge #3057 first as you mentioned in its description.
Addressed your comments and renamed it to |
Now that #3057 is merged we can go back to this one, just merged master into here. Feel free to take a look when you get a chance @acheroncrypto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
Resolves #3050