idl: Make safety comment checks fail silently when program path env is not set #3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
acheroncrypto
added
lang
idl
|
Blocked by #3044 |
|
Merging with (unrelated) CI errors because solana-labs/solana-program-library#6897 is taking a while to get resolved. |
|
Still the issue hasn't been resolved. @acheroncrypto |
|
It has been resolved, but we don't have a release with this PR included. This is a LSP only issue, and I've shared multiple ways to fix it in #3042 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
IDL generation expects
ANCHOR_IDL_BUILD_PROGRAM_PATHenvironment variable to be set, but if the user is using Rust Analyzer with all features enabled, they will run into a panic due the environment variable not being set as described in #3042.Summary of changes
Make safety comment checks fail silently when the
ANCHOR_IDL_BUILD_PROGRAM_PATHenvironment variable is not set.Note that the checks still work as expected, this is only to improve an LSP related issue.
Resolves #3042