-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix missing filename in 'Unable to read keypair file' errors #2932
fix missing filename in 'Unable to read keypair file' errors #2932
Conversation
@mikemaccana is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
1082d2d
to
0b9540c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
This currently is missing some parts, please search for read_keypair_file
in your editor and fix all of them. Just to give an example:
Lines 3620 to 3622 in 0b9540c
solana_sdk::signature::read_keypair_file(path) | |
.map_err(|_| anyhow!("Unable to read keypair file"))? | |
.pubkey(), |
is not handled in this PR.
254da4c
to
876f404
Compare
Thanks. I did try and make get_keypair() take a path instead originally but read_keypair_file() really wants the trait
Missed that one (originally I skipped it when playing with WalletPath as it wants a string). Got it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I did try and make get_keypair() take a path instead originally but read_keypair_file() really wants the trait
AsRef<std::path::Path>
andWalletPath
doesn't implement it. I ended up converting to a string in this most recent update, is there a better way?
Taking in &str
would be better than String
.
read_keypair_file
in your editor and fix all of themMissed that one (originally I skipped it when playing with WalletPath as it wants a string). Got it now.
Thanks, there are 2 more though:
Lines 1268 to 1269 in 499e1e6
solana_sdk::signature::read_keypair_file(file.path()) .map_err(|_| anyhow!("failed to read keypair for program: {}", self.lib_name)) Lines 534 to 535 in 499e1e6
solana_sdk::signature::read_keypair_file(&self.provider.wallet.to_string()) .map_err(|_| anyhow!("Unable to read keypair file"))
1285166
to
b5a7577
Compare
b5a7577
to
f8a2284
Compare
f8a2284
to
ac9beec
Compare
Use named placeholders in formatting Co-authored-by: acheron <[email protected]>
ac9beec
to
e9797a1
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #2884