Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lang: Remove AccountInfo from Context #2470

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

lang: Remove AccountInfo from Context #2470

wants to merge 13 commits into from

Conversation

Aursen
Copy link
Contributor

@Aursen Aursen commented Apr 25, 2023

No description provided.

@vercel
Copy link

vercel bot commented Apr 25, 2023

@Aursen is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@Aursen
Copy link
Contributor Author

Aursen commented Apr 26, 2023

Blocked here: tokio-rs/tokio#5655

@Aursen Aursen marked this pull request as ready for review April 26, 2023 11:32
@Aursen
Copy link
Contributor Author

Aursen commented Apr 26, 2023

What has changed:

  • Replaced all AccountInfo with UncheckedAccount in tests.
  • Added a new attribute to use AccountInfo on structures (useful in cross program internal invocation).
  • Removed abusive .clone() in the spl.
  • Added an indication on the fields to prevent the use of the AccountInfo type.
  • Removal of the CHECK on the AccountInfo type.

acheroncrypto
acheroncrypto reviewed Apr 26, 2023
View reviewed changes
lang/derive/accounts/src/lib.rs Outdated Show resolved Hide resolved
lang/src/accounts/account_info.rs Outdated Show resolved Hide resolved
lang/syn/src/codegen/accounts/mod.rs Outdated Show resolved Hide resolved
@acheroncrypto acheroncrypto mentioned this pull request Apr 29, 2023
Merged
Aursen added 4 commits May 5, 2023 10:00
@Aursen
Remove AccountInfo
0341e29
@Aursen
Squashed commit of the following:
5281720 
commit ac86e15
Author: Matthew Callens <[email protected]>
Date:   Wed May 3 17:53:46 2023 -0500

    spl: remove mpl `create_metadata_account_v2` wrapper that were removed from program (coral-xyz#2480)

    * remove mpl ix wrappers that were removed from program

    * update changelog

commit c166712
Author: acheron <[email protected]>
Date:   Wed May 3 09:09:41 2023 +0200

    bench: Add a script to sync benchmark results for all versions (coral-xyz#2477)

commit a195106
Author: acheron <[email protected]>
Date:   Mon May 1 13:39:50 2023 +0200

    spl: Use fixed version for `winnow` crate to fix new builds (coral-xyz#2478)

commit 03b1e4d
Author: acheron <[email protected]>
Date:   Thu Apr 27 12:10:23 2023 +0200

    Upgrade `clap` to 4.2.4 (coral-xyz#2474)

commit 876ef41
Author: Proph3t <[email protected]>
Date:   Thu Apr 27 08:53:04 2023 +0000

    docs: fix broken links in `AccountLoader` docs (coral-xyz#2473)

commit c14ae6b
Author: Tuan Pham Minh <[email protected]>
Date:   Wed Apr 26 00:07:39 2023 +0700

    Fix typo of `is_signer` field in intro-to-solana docs page (coral-xyz#2469)
@Aursen
Merge branch 'master' into account-info
cd3d36e
@Aursen
Fix boxed accounts
2f6ddbe
@Aursen Aursen requested a review from acheroncrypto May 5, 2023 10:20
Aursen added 5 commits June 10, 2023 12:55
@Aursen
Squashed commit of the following:
d8ace33 
commit e1afcbf
Author: acheron <[email protected]>
Date:   Fri Jun 9 18:00:35 2023 +0200

    v0.28.0 (coral-xyz#2527)

commit c7c7319
Author: acheron <[email protected]>
Date:   Thu Jun 8 18:59:44 2023 +0200

    Allow wider range of dependency versions to reduce dependency issues (coral-xyz#2524)

commit 6df34e7
Author: acheron <[email protected]>
Date:   Wed Jun 7 19:12:56 2023 +0200

    Update crate authors and remove outdated registry (coral-xyz#2522)

commit 1705d16
Author: Jean Marchand (Exotic Markets) <[email protected]>
Date:   Wed Jun 7 16:29:23 2023 +0200

    docs: Add doc for InitSpace macro (coral-xyz#2521)

commit 3d7c97b
Author: acheron <[email protected]>
Date:   Tue Jun 6 19:28:24 2023 +0200

    cli: Accept program lib name for `anchor deploy --program-name` (coral-xyz#2519)

commit a88be42
Author: Sergo <[email protected]>
Date:   Tue Jun 6 14:07:33 2023 +0300

    ts: Validate `error.data` exists on simulation response (coral-xyz#2508)

commit 65c9d6e
Author: Jean Marchand (Exotic Markets) <[email protected]>
Date:   Tue Jun 6 09:43:46 2023 +0200

    client: Add async to anchor-client (coral-xyz#2488)

    Co-authored-by: acheron <[email protected]>

commit b8eda69
Author: Deep Mehta <[email protected]>
Date:   Mon Jun 5 22:35:24 2023 +0530

    cli: Print not found message if the given program cannot be found during deployment (coral-xyz#2517)

commit 1902b8e
Author: CanardMandarin <[email protected]>
Date:   Mon Jun 5 14:16:10 2023 +0200

    cli: Update programs in `Anchor.toml` when using `anchor new` (coral-xyz#2516)

commit 383e440
Author: acheron <[email protected]>
Date:   Sun Jun 4 21:02:16 2023 +0200

    cli: Initialize with the correct program id (coral-xyz#2509)

commit 835dc5b
Author: Sarfaraz Nawaz <[email protected]>
Date:   Sun Jun 4 23:20:03 2023 +0530

    lang: Rename derive_anchor_deserialize -> derive_init_space (coral-xyz#2510)

commit 1c6f86e
Author: acheron <[email protected]>
Date:   Sun Jun 4 13:09:39 2023 +0200

    Upgrade Solana to 1.16.0 (coral-xyz#2512)

commit 2bf8afe
Author: acheron <[email protected]>
Date:   Tue May 30 19:50:45 2023 +0200

    cli: Use `confirmed` commitment level in commands (coral-xyz#2506)

commit 70d9223
Author: acheron <[email protected]>
Date:   Sun May 28 22:34:53 2023 +0200

    cli: Add `anchor keys sync` command (coral-xyz#2505)

commit 0c8498d
Author: cavemanloverboy <[email protected]>
Date:   Sat May 27 06:53:02 2023 -0700

    cli: Exit `anchor clean` without error when dirs don't exist (coral-xyz#2504)

commit 23b90bf
Author: Noah Gundotra <[email protected]>
Date:   Fri May 26 12:36:46 2023 -0400

    Feature: CPI Events API (coral-xyz#2438)

    Co-authored-by: acheron <[email protected]>

commit c3625c8
Author: Last Emperor <[email protected]>
Date:   Wed May 24 15:05:47 2023 +0300

    examples: Add an example with `instruction` method (coral-xyz#2501)

    Co-authored-by: acheron <[email protected]>

commit 67eb752
Author: acheron <[email protected]>
Date:   Sat May 20 20:34:38 2023 +0200

    tests: Fix zero-copy tests (coral-xyz#2498)

commit f9d0eca
Author: acheron <[email protected]>
Date:   Fri May 19 13:18:14 2023 +0200

    spl: Update `spl-token-2022` to 0.6.1 (coral-xyz#2496)

commit 4793b90
Author: acheron <[email protected]>
Date:   Fri May 19 10:58:16 2023 +0200

    Fix `toml_datetime` 1.64.0 MSRV error (coral-xyz#2495)

commit 41a4d82
Author: chalda <[email protected]>
Date:   Thu May 18 19:12:25 2023 +0200

    cli: Add print base64 instruction option for some of the IDL commands (coral-xyz#2486)

    Co-authored-by: acheron <[email protected]>

commit b7bada1
Author: Pierre <[email protected]>
Date:   Tue May 16 23:46:40 2023 +1000

    fix: remove skip preflight from cli (coral-xyz#2492)

    ---------

    Co-authored-by: acheron <[email protected]>

commit 89e94d1
Author: Ryan De La O <[email protected]>
Date:   Sat May 13 02:17:47 2023 -0700

    cli: Fix incorrect metadata.address generation (coral-xyz#2485)

    Currently when running 'anchor deploy --program-name <name> --program-keypair <specified keypair>' the cli still uses the auto-generated keypair when fetching the program id to add to the IDL metadata at the end. It should instead use the address from the specified keypair.

    ---------

    Co-authored-by: acheron <[email protected]>

commit 714d524
Author: CanardMandarin <[email protected]>
Date:   Tue May 9 16:17:11 2023 +0200

    lang: Add error message when Mint and TokenAccount with `init` are not ordered correctly (coral-xyz#2484)

commit 9a93a2e
Author: James <[email protected]>
Date:   Mon May 8 10:17:51 2023 +0100

    ts: Improve IDL typing (coral-xyz#2482)

    * Use XOR pattern for enum variants to prevent two variants being used at the same time.

    * Fix unknown for types like Option<[u8; 32]>

commit d1ddf00
Author: CanardMandarin <[email protected]>
Date:   Sun May 7 11:03:37 2023 +0200

    lang: Fix incorrectly checking the first init constraint (coral-xyz#2483)
@Aursen
Merge branch 'master' into account-info
7209d3a
@Aursen
Fix event_cpi
4815e0a
@Aursen
Update changelog
4eb602e
@Aursen
Update bench
035e746
@Aursen
Copy link
Contributor Author

Aursen commented Jun 16, 2023

@acheroncrypto I think this PR is ready, I will handle the rest in another PR

@acheroncrypto
Copy link
Collaborator

Thanks, I'll have to test this locally before merging. How did you fix the bench issue?

@Aursen
Copy link
Contributor Author

Aursen commented Jun 16, 2023

Thanks, I'll have to test this locally before merging. How did you fix the bench issue?

I did it with fresh packages and cache cleaned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acheroncrypto acheroncrypto Awaiting requested review from acheroncrypto

Assignees
No one assigned
Labels
breaking lang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aursen @acheroncrypto