Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulate: Don't attempt to sign transaction #2331

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Simulate: Don't attempt to sign transaction #2331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a4d8e3
Simulate: Only sign when `signers` is non-null
ckamm Jul 14, 2022
5ed3922
add changelog
Jan 17, 2023
c075808
Merge branch 'master' into ckamm/simulate-without-sign
Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ The minor version will be incremented upon a breaking change and the patch versi

### Fixes

- cli: Don't regenerate idl in read_all_programs(). ([#2332](https://github.com/coral-xyz/anchor/pull/2332))
- cli: Don't regenerate idl in read_all_programs(). ([#2332](https://github.com/coral-xyz/anchor/pull/2332)).
- ts: `provider.simulate` will send the transaction with `sigVerify: false` if no `signers` are present ([#2331](https://github.com/coral-xyz/anchor/pull/2331)).

### Breaking

Expand Down
9 changes: 7 additions & 2 deletions ts/packages/anchor/src/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,10 @@ export class AnchorProvider implements Provider {
* Simulates the given transaction, returning emitted logs from execution.
*
* @param tx The transaction to send.
* @param signers The signers of the transaction.
* @param signers The signers of the transaction. If unset, the transaction
* will be simulated with the "sigVerify: false" option. This
* allows for simulation of transactions without asking the
* wallet for a signature.
* @param opts Transaction confirmation options.
*/
async simulate(
Expand All @@ -263,7 +266,9 @@ export class AnchorProvider implements Provider {
)
).blockhash;

tx = await this.wallet.signTransaction(tx);
if (signers) {
tx = await this.wallet.signTransaction(tx);
}
const result = await simulateTransaction(
this.connection,
tx,
Expand Down