feat: Add has_one relations inference so you don't need to pass accounts that are referenced by a has_one #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChewingGlass is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
|
Nooahhhhh |
lang/syn/src/idl/file.rs
Outdated
| @@ -18,6 +18,7 @@ pub fn parse( | |||
| filename: impl AsRef<Path>, | |||
| version: String, | |||
| seeds_feature: bool, | |||
| relations_feature: bool, | |||
There was a problem hiding this comment.
Should we combine this with the seeds_feature ?
There was a problem hiding this comment.
The nomenclature isn't accurate but the intention is the same.
There was a problem hiding this comment.
Up to you. You mean keep the same name? seeds = true
…s/anchor into feature/relations-derivation
Henry-E
pushed a commit
to Henry-E/anchor
that referenced
this pull request
Dec 6, 2022
…nts that are referenced by a has_one (coral-xyz#2160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to PDA inference. In typescript, you can now avoid passing to
.accounts()accounts that can be resolved by fetching and pulling fields off of provided public keys.Also added a few handy methods I'd like to see. Can remove if needed.
See the tests/ repo for more details.