Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts: fix methods namespace typing loss and deprecate non-methods namespaces #1539

Merged
merged 3 commits into from
Mar 2, 2022
Merged

ts: fix methods namespace typing loss and deprecate non-methods namespaces #1539

merged 3 commits into from
Mar 2, 2022

Conversation

callensm
Copy link
Member

@callensm callensm commented Mar 1, 2022

resolves #1434
resolves #1442

@armaniferrante armaniferrante merged commit 80be428 into coral-xyz:master Mar 2, 2022
@danmt danmt mentioned this pull request Mar 3, 2022
Closed
@callensm callensm mentioned this pull request Mar 3, 2022
Merged
NBNARADHYA pushed a commit to MLH-Fellowship/anchor that referenced this pull request Mar 8, 2022
@callensm @NBNARADHYA
ts: fix methods namespace typing loss and deprecate non-methods names…
6a00d62 
…paces (coral-xyz#1539)
NBNARADHYA pushed a commit to MLH-Fellowship/anchor that referenced this pull request Mar 9, 2022
@callensm @NBNARADHYA
ts: fix methods namespace typing loss and deprecate non-methods names…
bbe3516 
…paces (coral-xyz#1539)
NBNARADHYA pushed a commit to MLH-Fellowship/anchor that referenced this pull request Mar 9, 2022
@callensm @NBNARADHYA
ts: fix methods namespace typing loss and deprecate non-methods names…
7f09b3c 
…paces (coral-xyz#1539)
NBNARADHYA pushed a commit to MLH-Fellowship/anchor that referenced this pull request Mar 9, 2022
@callensm @NBNARADHYA
ts: fix methods namespace typing loss and deprecate non-methods names…
f7a7e67 
…paces (coral-xyz#1539)
NBNARADHYA pushed a commit to MLH-Fellowship/anchor that referenced this pull request Mar 9, 2022
@callensm @NBNARADHYA
ts: fix methods namespace typing loss and deprecate non-methods names…
eea4f9c 
…paces (coral-xyz#1539)
NBNARADHYA pushed a commit to MLH-Fellowship/anchor that referenced this pull request Mar 9, 2022
@callensm @NBNARADHYA
ts: fix methods namespace typing loss and deprecate non-methods names…
b9977dd 
…paces (coral-xyz#1539)
@Beardev118
Copy link

Which method can use instead of deprecated rpc?

@callensm
Copy link
Member Author

the program.methods namespace is now the preferred namespace to use.

@Beardev118
Copy link

Okay, thank you

@gabRiel-bit20
Copy link

Will be worth add some documentation pointing to methods when marking rpc, instruction deprecated.

@callensm callensm mentioned this pull request Apr 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@callensm @Beardev118 @gabRiel-bit20 @armaniferrante