-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ts: fix Wallet
class declaration
#1363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, is that pushed to the latest npm package ? I am trying to use it but getting errors - `import {Wallet} from "@project-serum/anchor"; const wallet = new Wallet(USER_KEYPAIR); throws this error: Type 'NodeWallet' has no construct signatures. |
@devanshsanghvi this hasn't been merged into |
losman0s
pushed a commit
to losman0s/anchor
that referenced
this pull request
Feb 7, 2022
archseer
added a commit
to smartcontractkit/chainlink-solana
that referenced
this pull request
Feb 11, 2022
archseer
added a commit
to smartcontractkit/chainlink-solana
that referenced
this pull request
Feb 11, 2022
archseer
added a commit
to smartcontractkit/chainlink-solana
that referenced
this pull request
Feb 11, 2022
archseer
added a commit
to smartcontractkit/chainlink-solana
that referenced
this pull request
Feb 14, 2022
EliteDev9472
added a commit
to EliteDev9472/chainlink-solana
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
Wallet
type declaration at the package root was declared as aconst
of typeNodeWallet
. This doesn't work and causes typing issues since nowWallet
is a variable and not an instantiable class.I changed the declaration so that
Wallet
is now a "new class" that extends the functionality ofNodeWallet
allowing it to maintain its class identify and instantiability.