inbox warning #489
Merged
inbox warning #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staab
requested changes
Nov 25, 2024
src/partials/Channel.svelte
Outdated
Comment on lines
67
to
71
| pubkeys.filter( | ||
| pubkey => | ||
| !$inboxRelayPoliciesByPubkey.has(pubkey) || | ||
| !$inboxRelayPoliciesByPubkey.get(pubkey).publicTags.length, | ||
| ), |
There was a problem hiding this comment.
You can use getListTags($inboxRelayPoliciesByPubkey.get(pubkey)).length === 0 without having to check has since getListTags accepts undefined.
|
One very minor change for conciseness, otherwise looks good. You're right that the other warning is redundant, but I think we can leave it, since we really don't want people bypassing the warning. |
ticruz38
force-pushed
the
feat/inbox-warning
branch
from
a51d850
to
846f0a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it looks like at the bottom of the chat history
There is another warning, once the user hit send, in a confirmation modal. You probably want to remove this one.
There was also an issue once you remove all your inbox relay, your npub still exist in the inboxPoliciesByPubkey store mapping, but the publicTags list is empty. I took this into consideration as well to check if you have any inbox relay.