Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mentions #166

Closed
Giszmo opened this issue Sep 29, 2023 · 2 comments
Closed

Improve mentions #166

Giszmo opened this issue Sep 29, 2023 · 2 comments

Comments

@Giszmo
Copy link

Giszmo commented Sep 29, 2023

As Coracle supports editing the mentions:
Average Joe has no clue about the difference between

  • @<somebody>: somebody gets mentioned in a p-tag, triggering a notification
  • nostr:<somebody's npub>: somebody only gets mentioned in the body of the text but not in a p-tag, avoiding a notification
  • nostr:<somebody's npub> plus p-tag: Some advocate for this approach to not use different formats in the content

Coracle already lists the p-tag mentions resulting from the thread, allowing the user to delete them but there are issues:

  • the user cannot add p-tag mentions. For example if he decided to remove some from the list, he can't add them back.
  • the user can't reference profiles without notifications easily

I suggest to

  • add profiles to the mentions-box as the user mentions them using the "@" syntax
  • show each mention with a 🔈 symbol instead of the ❌
  • clicking the 🔈 turns it into 🔇 (and puts it to the end of the list, so the user can quickly mute many without moving the mouse)
  • user can enter further mentions in the mentions box that get added via p-tags without being referenced in the text
@staab
Copy link
Collaborator

staab commented Sep 29, 2023

I think it's ok as is. Coracle converts inline npubs to p tags anyhow following approach #3, so use case #2 isn't supported. So if someone wants to mention someone they can just @ them at the bottom of the note, which is idomatic. Maybe @dtonon disagrees, but I think this is ok.

@staab staab closed this as completed Sep 29, 2023
@dtonon
Copy link
Member

dtonon commented Sep 30, 2023

I agree with @staab, the average Joe mentions using @, so he should not be worried by any other format.

Adding the possibility to notify without a visible mention doesn't seem so useful, for the mentioned user can be counterintuitive (he cannot see himself in the message) and it's prone to spam behaviors.

But I agree that the removal interface can be improved a little with a toggle style, to permit adding back a user removed by error. @Giszmo UX specs for this are okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants