Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict files used for profile image #3

Closed
ghost opened this issue Dec 16, 2022 · 3 comments
Closed

Restrict files used for profile image #3

ghost opened this issue Dec 16, 2022 · 3 comments

Comments

@ghost
Copy link

ghost commented Dec 16, 2022

Do not allow users to upload any file type, without any restrictions on file size or type. An attacker could potentially upload a malicious image file.

I tested by uploading QR code image, pdf etc. generated here: https://canarytokens.org/generate

@fiatjaf
Copy link
Contributor

fiatjaf commented Dec 16, 2022

If you are an attacker can't you just host your poisoned image elsewhere and use https://metadata.nostr.com/ to update your profile?

@ghost
Copy link
Author

ghost commented Dec 16, 2022

Yes its possible however clients can still use some sanitization for user profile images.

@staab
Copy link
Collaborator

staab commented Dec 16, 2022

What is a poisoned image? Are we just talking about ip leakage and read receipts? If so, I'm not sure how you can have a full-featured UX without running afoul of that. The same vulnerability would apply to any clickable link too. In the future I might add a setting to turn off images/links, or proxy them through a server, but it's not a huge priority for coracle right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants