feat: show message when goals are unfocused #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are unfocused goals (when bullets are used) we now display a message stating the subproof is complete but there are still unfocused goals.
| collapseGoalHandler={(id) => collapseGoalHandler(id, ProofViewGoalsKey.main)} | ||
| displaySetting={displaySetting} | ||
| emptyMessage={ | ||
| goals!.shelved.length ? "There are shelved goals. Try using `Unshelve.`" : | ||
| goals!.givenUp.length ? "There are some goals you gave up. Go back and solve them, or use `Admitted.`" : | ||
| goals!.unfocused.length ? "The subproof is complete, but there are some unfocused goals. Focus next goal with bullet -." : |
There was a problem hiding this comment.
Is it maybe a bit confusing to specify - as the bullet type to use when it could be any of them
There was a problem hiding this comment.
Yes, I think we had a discussion with @SkySkimmer about the API to use here (or to suggest the right bullet as a quickfix if the wrong one is used)
There was a problem hiding this comment.
I'll change this to make the bullet suggestion non specific and I'll display the unfocused goals as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are unfocused goals (when bullets are used) we now display a message stating the subproof is complete but there are still unfocused goals.
Closes #643