[parser] use the loc of the prev sentence to feed the parser #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gares
added a commit
to LPCIC/coq-elpi
that referenced
this pull request
Jul 10, 2024
In this way the line number in the loc is not reset to 0. This has no use internally, since the document holds the text and computes line number correctly, but Coq code and plugins may want to display a loc (with a correct line number)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this way the line number in the loc is not reset to 0. This has no use internally, since the document holds the text and computes line number correctly, but Coq code and plugins may want to display a loc (with a correct line number).
Note that the char-number is correct, since it comes from the stream, apparently.
This makes errors reported by Coq-Elpi more precise.