Fix message panel colors #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into an issue when using VsCoq with a custom theme: most of the text in the Search panel (in the proof view) was black on black.
For some reason, this color is set to
editorInfo.background, which is what was causing the issue (the background color being set to almost full transparency).I fixed it to use
editorInfo.foregroundinstead, and fixed a similar line for type hints. Note that the Search command itself still renders usingeditorInfo.backgroundwith this fix.The issue doesn't crop up with most themes since they don't define
editorInfo.backgroundso the CSS probably inherits from parent elements that useeditor.foreground.