-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coq-simple-io.dev : remove dune upper bound #3011
base: master
Are you sure you want to change the base?
Conversation
The upper bound was to work around a bug (discussed here) that manifests itself on opam CI with dune 3.14. So if this PR doesn't pass CI, a more local workaround may be to allow newer dunes only in downstream configs such as QuickChick CI. |
@erikmd is it worth downgrading the Dune version for coqorg/coq? Currently dev packages either fail the CI here or cannot be installed on the Docker images. |
Hi @liyishuai ! thanks for the ping. Sure, this is easy to do. Which version of Dune would be OK? |
Maybe 3.13.1 ? unless the latest releases 3.15.0 / 3.15.1 would fix the issue you speak about? |
Hi @liyishuai, the downgrade is complete, see e.g.:
Do you think you could file an issue in Dune's repo if it is not already the case? Also Cc @ybertot FYI |
Now there's https://github.com/ocaml/dune/releases/tag/3.15.2. Maybe worth testing it on Coq CI. |
as the Coq docker images have pinned Dune to 3.14.