Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coq-simple-io.dev : remove dune upper bound #3011

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liyishuai
Copy link
Member

as the Coq docker images have pinned Dune to 3.14.

@Lysxia
Copy link
Contributor

Lysxia commented Apr 8, 2024

The upper bound was to work around a bug (discussed here) that manifests itself on opam CI with dune 3.14. So if this PR doesn't pass CI, a more local workaround may be to allow newer dunes only in downstream configs such as QuickChick CI.

@liyishuai
Copy link
Member Author

@erikmd is it worth downgrading the Dune version for coqorg/coq? Currently dev packages either fail the CI here or cannot be installed on the Docker images.
coq-community/docker-base@c6bff64

@erikmd
Copy link
Member

erikmd commented Apr 23, 2024

Hi @liyishuai ! thanks for the ping.

Sure, this is easy to do. Which version of Dune would be OK?

@erikmd
Copy link
Member

erikmd commented Apr 23, 2024

Maybe 3.13.1 ?

unless the latest releases 3.15.0 / 3.15.1 would fix the issue you speak about?

https://github.com/ocaml/dune/releases

erikmd added a commit to coq-community/docker-base that referenced this pull request Apr 23, 2024
@erikmd
Copy link
Member

erikmd commented Apr 23, 2024

Hi @liyishuai, the downgrade is complete, see e.g.:

Do you think you could file an issue in Dune's repo if it is not already the case?

Also Cc @ybertot FYI

@liyishuai liyishuai marked this pull request as draft April 23, 2024 10:15
@liyishuai
Copy link
Member Author

Now there's https://github.com/ocaml/dune/releases/tag/3.15.2. Maybe worth testing it on Coq CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants