Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coq-metacoq-template.8.17.dev #2904

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Fix coq-metacoq-template.8.17.dev #2904

merged 2 commits into from
Jan 24, 2024

Conversation

liyishuai
Copy link
Member

@liyishuai liyishuai commented Jan 17, 2024

@liyishuai
Copy link
Member Author

The CI of #2893 should have complained that coq-metacoq-template-pcuic cannot compile. Maybe need a different timeout strategy.

@liyishuai
Copy link
Member Author

Maybe worth merging asynchronously from MetaCoq/metacoq#1023.

@silene
Copy link
Contributor

silene commented Jan 18, 2024

The CI of #2893 should have complained that coq-metacoq-template-pcuic cannot compile. Maybe need a different timeout strategy.

It did complain. Unfortunately, when there is a timeout, one has to go and read the logs to check whether the timeout is hiding a real compilation error. I suppose we could set the variable RUNNER_SCRIPT_TIMEOUT to something like 150m, so that the cumulative time of before_script and script does not exceed 3 hours, and then have an after_script that checks whether there was an actual compilation failure and reports it more prominently in the logs.

@liyishuai
Copy link
Member Author

Now passes CI.
Propose merging for now, and reverting c292c3b after the compatibility issue gets fixed.

@palmskog palmskog merged commit eaeb647 into coq:master Jan 24, 2024
3 checks passed
@liyishuai liyishuai deleted the patch-1 branch January 24, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants