-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated JSON data does not contain any link to the sources of the packages. #804
Comments
Now that you mention the CoqGym use case, this is indeed an open problem in the upstream OCaml / OPAM world, you have the dune-universe repositories but a solution for a coherent view on the package world has still not been developed AFAICT. There are some issues lurking around tho. |
Yes, I plan to add all the necessary metadata. In fact, we may want to generate OPAM and Nix packages from the metadata at some point (so they should contain URLs to the source, build instructions, etc). For now, the JSON data contains only what is needed by the web interface (I wanted to achieve separation between the website and the package index). |
Has there been any progress on this? I'm curious about CoqGym/coq_hammer. |
I personally won't have time to work on it before September, I'm afraid. |
@maximedenes It's September ;-) |
Working on it now. |
It seems that a few packages do not use the standard I couldn't find a documentation of the allowed attributes, so I'm adding support only for |
Switched to OCaml 4.08 to use some convenient additions to OCaml's stdlib. Fixes coq#804
@maximedenes from the OPAM manual the allowed attributes are: "One of So basically |
Ah, thanks a lot! I guess I'll support the two non-deprecated names. Will update my PR. |
We could also do a pass on the repository to fix all the deprecated fields... |
Switched to OCaml 4.08 to use some convenient additions to OCaml's stdlib. Fixes coq#804
This is quite unfortunate as it does not allow to solve the issue that was raised in this thread: https://coq.discourse.group/t/coqhammer-1-1-1-for-coq-8-9/327.
The CoqGym (@yangky11) people crawled the Coq package index to get the URLs of packages.
Now they could obtain exactly the same results by doing
cat coq-packages.json | jq '.[][1].versions[0].homepage'
, which is already an improvement.However, it doesn't solve their bug which is to confuse the homepage of a package and the repository URL. It just happened that this confusion gave them correct results in most cases, but not for instance for math-classes and corn (as remarked by @spitters).
Would it be doable to add more meta-information to reflect, both the repository as declared in the opam meta-data, but also the URL of sources, which is defined there as well?
The text was updated successfully, but these errors were encountered: