Split github CI actions into 2 workflows + disable windows while it's broken

[SkySkimmer]

To be able to rerun one OS without rerunning the other.

[Zimmi48]

Another way of disabling the Windows workflow would have been to call it ci-windows.yml.disabled. This would make the diff easier to review when a fix for the Windows CI is submitted.

[Zimmi48]

BTW, the reason why the Windows CI fails seems to be simply because the dev-ci branch has been removed. Can you try to simply replace dev-ci with main and see what this gives?

[SkySkimmer]

BTW, the reason why the Windows CI fails seems to be simply because the dev-ci branch has been removed. Can you try to simply replace dev-ci with main and see what this gives?

Still not working (different error though)

[Zimmi48]

FWIW, the first error is the following one:

Run .\dev\ci\platform\coq-pf-03-build.bat
Install cygwin and download, compile and install OCaml and Coq for MinGW
!!! Illegal parameter -override-dev-pkg

The call is done in:

coq/dev/ci/platform/coq-pf-03-build.bat

Lines 14 to 24 in 24a705b

	call coq_platform_make_windows.bat ^
	-arch=%ARCH% ^
	-destcyg=%CYGROOT% ^
	-cygcache=%CYGCACHE% ^
	-extent=i ^
	-parallel=p ^
	-jobs=2 ^
	-switch=d ^
	-override-dev-pkg="coq=%GITHUB_SERVER_URL%/%GITHUB_REPOSITORY%/archive/%GITHUB_SHA%.tar.gz" ^
	-override-dev-pkg="coqide=%GITHUB_SERVER_URL%/%GITHUB_REPOSITORY%/archive/%GITHUB_SHA%.tar.gz" ^
	|| GOTO ErrorExit

@MSoegtropIMC The Windows CI is failing for Coq because the dev-ci branch of the Platform repository has been removed, and it had an -override-dev-pkg option that is not there in the main branch. We will need your help to fix this (but this is OK to wait until after the next Platform release to take care of this, we can disable the CI job as proposed in this PR in the meantime).

[Zimmi48]

Will merge after confirming that macOS CI passes.

[MSoegtropIMC]

@Zimmi48 : OK, I cleaned up a bit too much. What would you recommend? I don't think I still want the dev-ci branch since it is effort to maintain it.

I now have a working dev pick, but it points to master for all packages.

I guess it would make sense to create a "ci" pick which honors the -override-dev-pkg option and/or possibly also takes the overlay information for -extent=f and -extent=x. @gares started something like this in coq/platform#44.

[Zimmi48]

@coqbot merge now

[Zimmi48]

@MSoegtropIMC Indeed, I agree that reintroducing the dev-ci branch is not a good solution. Furthermore, we don't need to test the full extent, just Coq + CoqIDE. And we can't just test the master branch of Coq, we need to be able to point to a local version to be able to test PRs. So basically, we just need an option similar to -override-dev-pkg to define specifically where to look for the source of Coq.

[MSoegtropIMC]

OK, I will add a ci pick which at first only contains coq + coqide (f and x extents will be empty) and which honors the -override-dev-pkg flag.

In addition I would mid term like to have a pick which mimics Coq's CI. Any suggestions how these two picks should be named?

[Zimmi48]

"dev"?

[MSoegtropIMC]

There is already a "dev" pick which uses the dev opam packages (that is default branch) for all packages.

In addition I propose to have two picks:

• pick which is used in Coq's CI to test Coq and CoqIDE on Windows
• pick which is intended for maintainers and creates a full Coq Platform using the same versions of all packages as Coq CI does.

For package maintainers the latter might be more useful than the dev pick. The dev pick is mostly for me to know where issues are.

Maybe

dev (opam .dev)
dev-coq (coq's ci pick)
ci-coq (for coq's CI)

[Zimmi48]

Sounds good to me.

[SkySkimmer]

Looks like I'm backporting this since it's also broken for 8.15