propagate hash fragment (=href anchor) when redirecting URLs #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When redirecting requests for stdlib or refman pages, propagate the URL's fragment identifer (the string following the '#' sign, if any). This is required for stdlib URLs so that links generated by coqdoc resolve to specifc identifiers, as intended. While at it, also preserve the fragment identifier in refman pages, in case someone, somewhere meant to link to specific parts of the reference manual. Fixes: coq#235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When redirecting requests for stdlib or refman pages, propagate the
URL's fragment identifer (the string following the '#' sign, if any).
This is required for stdlib URLs so that links generated by coqdoc
resolve to specifc identifiers, as intended.
While at it, also preserve the fragment identifier in refman pages, in
case someone, somewhere meant to link to specific parts of the
reference manual.
Fixes: #235
Aside: tweaked
srv/server.pyto be able to test the 404 page locally.