Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update Nix CI #110

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Fix and update Nix CI #110

merged 2 commits into from
Dec 10, 2021

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Dec 10, 2021

I just realized by analyzing a strange success in an aac-tactics overlay that Nix CI was completely broken for PRs since #107 because I stupidly forgot to update the actions/checkout@v2 step.

The second commit is a port of coq-community/coq-nix-toolbox#81. I'm taking advantage that there will need to be an update of projects relying on Nix CI to do this change in passing.

I've tested that this works on the above-mentioned aac-tactics overlay.

@palmskog I can take care of updating the 9 coq-community projects using the nix-action tag. If you know of some other projects (e.g., external to coq-community) that also use this template, please make sure they are updated as well.

@Zimmi48 Zimmi48 merged commit e62015d into master Dec 10, 2021
@Zimmi48 Zimmi48 deleted the fix-and-update-nix-ci branch December 10, 2021 12:54
@palmskog
Copy link
Member

Thanks for catching this. I'm not aware of projects outside coq-community using the lightweight Nix CI. This is a bit of a shame, we should try to "sell" it more I think.

@palmskog
Copy link
Member

@Zimmi48 one more project in coq-community that uses Nix CI without having the nix-action tag: https://github.com/coq-community/reglang/blob/master/.github/workflows/nix-action.yml

We probably want to check with Christian if OK to add tags like nix-action and docker-coq-action.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Dec 10, 2021

@chdoc Is this OK for us to add tags to the reglang repo to denote what kind of CI is used inside and to directly push minor updates based on changes to the templates?

@chdoc
Copy link
Member

chdoc commented Dec 10, 2021

@chdoc Is this OK for us to add tags to the reglang repo to denote what kind of CI is used inside

Assuming that by "tag" you mean what GitHub calls "topics" rather than git tags, I'm okay with this.

and to directly push minor updates based on changes to the templates?

This is fine with me too.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Dec 10, 2021

Indeed, I meant topics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants