Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nix build on Travis CI (backport for v8.12) #43

Merged
merged 3 commits into from
Jun 20, 2020
Merged

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Jun 19, 2020

No description provided.

@erikmd erikmd requested a review from Zimmi48 June 19, 2020 22:32
@erikmd erikmd added the fix label Jun 19, 2020
@erikmd
Copy link
Member Author

erikmd commented Jun 20, 2020

Hi @vbgl, I've just realized a Coq 8.12 test was missing for this second PR.
Now fixed − and let's wait for the CI :)

@erikmd erikmd requested a review from vbgl June 20, 2020 10:16
@erikmd
Copy link
Member Author

erikmd commented Jun 20, 2020

CI is green ✔️

@vbgl vbgl merged commit 0bab136 into v8.12 Jun 20, 2020
@vbgl
Copy link
Contributor

vbgl commented Jun 20, 2020

Thanks.

Is someone willing to put a tag for 8.12?

@erikmd
Copy link
Member Author

erikmd commented Jun 20, 2020

Thanks @vbgl for the merge! regarding the 8.12.0 release of bignums, maybe there's no hurry and we can just wait for the Coq release itself? cf. the question I had asked in this thread: coq/coq#11157 (comment)

@erikmd erikmd deleted the fix-nix-travis branch June 20, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants