Add new network type "localhub" #1216
Open
+58
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copy
reviewed
Jan 25, 2025
| @@ -315,6 +315,10 @@ V86.prototype.continue_init = async function(emulator, options) | |||
| { | |||
| this.network_adapter = new FetchNetworkAdapter(this.bus, options.net_device); | |||
| } | |||
| else if(relay_url === "localhub") | |||
| { | |||
| this.network_adapter = new LocalhubNetworkAdapter(this.bus, options.net_device); | |||
There was a problem hiding this comment.
In terms the v86 API, I'm not too happy about the open-endedness of this network configuration (e.g., what if the user wants to mix this with web workers?). I'd prefer if users of the API used the net0-{send,receive} API instead.
Could you leave a comment here (or above the constructor) saying that this is experiment and might change at any time?
|
Maybe it makes sense to rewrite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new class
LocalhubNetworkAdapterwhich provides a simpleBroadcastChannel-based network to v86 guests.This networking method allows multiple v86 instances within the same browser process to communicate with each other like in a physical network, but without access to any external networks (it uses the same method as demonstrated in
examples/broadcast-network.html).The URL scheme (for
config.net_device.relay_url) of this new networking method islocalhub.Added it to the v86 web interface in
main.jsbecause it works out of the box and is a great method to get started with v86 networking.This PR is only meant to be a proposal, everything is up for debate, if this proposal should get rejected I'd be absolutely fine with the decision, of course.