Skip to content

Commit

Permalink
fix: Prevent watch stream from closing on recoverable error
Browse files Browse the repository at this point in the history
  • Loading branch information
sergiocampama committed Mar 14, 2024
1 parent be49849 commit b4d785d
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Firestore/core/src/remote/grpc_stream.cc
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,11 @@ std::shared_ptr<GrpcCompletion> GrpcStream::NewCompletion(
const std::shared_ptr<GrpcCompletion>& completion) {
RemoveCompletion(completion);

if (ok) {
if (ok || (completion->status()->ok() && completion->message()->Valid())) {
if (!ok) {
LOG_DEBUG("GrpcStream('%s'): operation of type %s failed, continuing", this,
completion->type());
}
if (on_success) {
on_success(completion);
}
Expand Down

0 comments on commit b4d785d

Please sign in to comment.