Fix macro expansion bug #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macro redir_memcopy expands to multiple statements. However, one of if-blocks where it is used lacks braces to form a block. This results in parts of the macro being executed even if not intended and triggers a compiler warning on modern GCC versions.
wlanmac
approved these changes
Aug 20, 2019
|
An alternative fix is here: https://github.com/openwrt/packages/blob/master/net/coova-chilli/patches/500-redir.patch Discussion: openwrt/packages#9336 (comment) I am not sure which is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro redir_memcopy expands to multiple statements. However, one of
if-blocks where it is used lacks braces for the code block. This results
in parts of the macro being executed even if not intended and triggers
a compiler warning on modern GCC versions.