Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nominations page #56

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

KKSurendran06
Copy link
Contributor

@KKSurendran06 KKSurendran06 commented Jan 14, 2024

Resolves #52

Changes -

  • I Removed the "Nominations" link from the navigation header.
  • I Implemented a conditional rendering approach to display a message indicating that nominations are closed and encourage users to return next year.

Highlights -

  • I Introduced a showNominations variable to control the visibility of the "Nominations" page.
  • I Modified the Nominations component to conditionally render a message indicating that nominations are currently closed.

Copy link
Collaborator

@scorpiontornado scorpiontornado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good, but should address my feedback before merging.

components/Navigation.jsx Show resolved Hide resolved
pages/nominations.jsx Show resolved Hide resolved
pages/nominations.jsx Outdated Show resolved Hide resolved
@KKSurendran06
Copy link
Contributor Author

Will do the changes but, I see you have used head tag but, head is not imported in the code. I will do a Pr fixing that

@scorpiontornado
Copy link
Collaborator

Thanks, nice catch

Copy link
Collaborator

@scorpiontornado scorpiontornado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll wait for @lhvy before merging though
image

@scorpiontornado
Copy link
Collaborator

Was considering utilising inline conditional rendering (e.g. ternary) to avoid repeated code like the head/title, and the fluff around the h1, but it ended up being too convoluted. I think how it is currently is the best solution, apart from a complete rewrite abstracting sections into different components like NomineeSection and NominationInfo.

Copy link
Collaborator

@scorpiontornado scorpiontornado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to request @lhvy rather than re-request review from myself, oops

Copy link
Collaborator

@lhvy lhvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Remember to add Resolves #xx to your PR description so the associated issue will close automatically.

@scorpiontornado scorpiontornado merged commit 5bb706b into coopsoc:main Jan 17, 2024
@KKSurendran06 KKSurendran06 deleted the nominations branch January 17, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove nominations page
3 participants