Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHG] rotordc_website_theme #109

Open
wants to merge 7 commits into
base: 12.0
Choose a base branch
from
Open

[CHG] rotordc_website_theme #109

wants to merge 7 commits into from

Conversation

remytms
Copy link
Member

@remytms remytms commented Dec 14, 2023

Description

Changes in rotor website theme

Odoo task (if applicable)

Task

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

@remytms remytms force-pushed the 12.0-rotordc_website_theme branch from 9ba9a5c to cb8a389 Compare December 15, 2023 10:14
@remytms
Copy link
Member Author

remytms commented Dec 15, 2023

Tests are broken because a dependency is not merged yet.

@remytms remytms requested a review from robinkeunen December 15, 2023 13:48
robinkeunen
robinkeunen requested changes Dec 15, 2023
View reviewed changes
Copy link
Member

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for the font.

Since the other module is back in our repository, couldn't you put all the product_availability formatting directly in the website_sale_product_availability module.

rotordc_website_theme/static/src/scss/rotordc.scss Show resolved Hide resolved
@remytms
Copy link
Member Author

remytms commented Dec 20, 2023 •
edited
Loading

Since the other module is back in our repository, couldn't you put all the product_availability formatting directly in the website_sale_product_availability module.

Design is always a question of taste. Our module wesbtite_sale_product_availability comes with a simple design which is good. RotorDC wants to change color and position, and that a preference that make sense in their custom theme module.

@remytms remytms requested a review from robinkeunen December 20, 2023 16:52
@remytms
Copy link
Member Author

remytms commented Dec 20, 2023

Tests are green. :)

@remytms remytms force-pushed the 12.0-rotordc_website_theme branch from 097d0e9 to af2d36e Compare January 11, 2024 17:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (3d6b7a7) 79.12% compared to head (100edde) 78.19%.
Report is 6 commits behind head on 12.0.

Files Patch % Lines
rotordc_sale_related_so/models/sale_order.py 75.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             12.0     #109      +/-   ##
==========================================
- Coverage   79.12%   78.19%   -0.94%     
==========================================
  Files          93       96       +3     
  Lines         939      963      +24     
  Branches      157      166       +9     
==========================================
+ Hits          743      753      +10     
- Misses        177      190      +13     
- Partials       19       20       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remytms
Copy link
Member Author

remytms commented Jan 25, 2024

/ocabot merge minor

@github-grap-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-109-by-remytms-bump-minor, awaiting test results.

github-grap-bot added a commit that referenced this pull request Jan 25, 2024
@github-grap-bot
Merge PR #109 into 12.0
dae6a50 
Signed-off-by remytms
@github-grap-bot
Copy link
Contributor

@remytms your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-109-by-remytms-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@remytms remytms force-pushed the 12.0-rotordc_website_theme branch from b7444f3 to ed5de3d Compare January 25, 2024 15:48
@remytms remytms force-pushed the 12.0-rotordc_website_theme branch from ed5de3d to 100edde Compare January 25, 2024 16:13
@carmenbianca carmenbianca mentioned this pull request Jan 25, 2024
Open
@remytms
Copy link
Member Author

remytms commented Jan 25, 2024

Finally, client changed his mind, and it should not be merged.

@remytms remytms force-pushed the 12.0-rotordc_website_theme branch from 100edde to afb60f8 Compare January 26, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinkeunen robinkeunen Awaiting requested review from robinkeunen

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@remytms @codecov-commenter @github-grap-bot @robinkeunen