Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Montage workflow example #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nkremerh
Copy link
Contributor

No description provided.

@dthain
Copy link
Member

dthain commented Dec 15, 2017

This looks like a modification of an existing program.
What's the original source?

@nkremerh
Copy link
Contributor Author

@dthain The mDAG.c file is from Montage. It is used to generate a DAX for Pegasus in their release, but it is modified to produce a makeflow for us. I will add proper documentation for that.

@nkremerh
Copy link
Contributor Author

Putting this pull request on hold as the version of Montage (C as opposed to the newer Python implementation) we use is no longer fully supported and relies on downloading some files (the pieces of the mosaic) which are no longer where they need to be for Montage to work.

@nkremerh nkremerh closed this Jun 28, 2018
@dthain
Copy link
Member

dthain commented Jun 28, 2018

Can you put some additional notes here about the "new" montage workflow,
so we have some breadcrumbs to review the problem in the future?

@dthain dthain reopened this Jun 28, 2018
@nkremerh
Copy link
Contributor Author

The new Montage workflow (https://github.com/pegasus-isi/montage-workflow-v2) is written in Python and uses the Pegasus DAX API. The older C version (and the Python version) both have issues with the data find functionality (downloading images to form the mosaic) at the time this comment was posted.

Our best bet going forward is that the Python version will get the fix for this, but the C version may not. Since the modified Montage makeflow generator we have been using is based on the C version, we need to think carefully about which iteration of Montage we plan on supporting or putting in the effort to get both working once the data find issue is resolved on their end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants