Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPOP-242 [gateway] [api-v1] fix: solve file upload issue for big files #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thomasAtCoopengo
Copy link

Fix #PPOP-242

Description

Issues in uploading large files through b2b and b2c.

Has this been tested ?

Yes, locally with a nevidis-recette environment.
In env.custom, add the following lines (example if we need to handle files as large as 30mb):

# Use this variable to fix the limit size of files passed through the gateway
MAX_LIMIT_FILE_SIZE_UPLOAD=30

# Use this to fix the max size of files passed to the API-v1 (coog-web)
COOG_API_PAYLOAD_LIMIT=30mb

As these env vars are already implemented in the code, making sure to use the right values for each customer will solve the issue encountered.

Tests have been conducted locally with the files attached here:
big_file.pdf
light_file.pdf

@thomasAtCoopengo thomasAtCoopengo requested a review from a team as a code owner September 18, 2023 09:44
@@ -32,6 +32,8 @@ services:
- JWT_EXPIRATION=${JWT_EXPIRATION:?}
- JWT_INTERNAL_ENCRYPTION=${JWT_INTERNAL_ENCRYPTION:?}

- MAX_LIMIT_FILE_SIZE_UPLOAD=${MAX_LIMIT_FILE_SIZE_UPLOAD:?}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- MAX_LIMIT_FILE_SIZE_UPLOAD=${MAX_LIMIT_FILE_SIZE_UPLOAD:?}
- MAX_LIMIT_FILE_SIZE_UPLOAD=${MAX_LIMIT_FILE_SIZE_UPLOAD:?}

@@ -1,3 +1,4 @@
* FIX#PPOP-242 Ajout des variables d'environnement dans les fichiers compose pour gérer la taille maximales des fichiers pouvant être upload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* FIX#PPOP-242 Ajout des variables d'environnement dans les fichiers compose pour gérer la taille maximales des fichiers pouvant être upload
* FIX#PPOP-242 Ajout des variables d'environnement dans les fichiers compose pour gérer la taille maximale des fichiers pouvant être upload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants