Add Skylight instrumentation #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discussed with @coopdevs about adding Skylight instrumentation to the TimeOverflow website under the new [Skylight for Open Source](https://www.skylight.io/oss) program. If you’re not already familiar with Skylight, it is a smart profiler for Rails apps. Skylight makes it easy to pinpoint performance issues in Rails applications. We work on a lot of open source projects ourselves, and in our experience it can be pretty hard to get contributors to work on application performance issues. Few contributors consider working on performance problems, and the ones that might be interested may not even know where to start. By making performance information more accessible, we hope to inspire potential contributors to tackle slow parts of your app, and have a good way to see if their contributions helped. Once this patch is merged and deloyed*, you will be able to view the performance data we collected at the [public Skylight dashboard](https://oss.skylight.io/app/applications/grDTNuzZRnyu). The dashboard will be accessible to anyone (no Skylight account required) to make it easy for contributors. (*Actually, I lied a little. We still need to set the `SKYLIGHT_AUTHENTICATION` environment variable to the appropiate API key on production, but I will work with @coopdevs on that off-thread.)
This was referenced Feb 5, 2018
|
Thanks for the PR @chancancode ! I assume we can safely merge and deploy this while we work on adding the env var, right? |
|
Yep! It might print a warning, but otherwise wouldn’t do anything! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discussed with @coopdevs about adding Skylight instrumentation to the TimeOverflow website under the new Skylight for Open Source program.
If you’re not already familiar with Skylight, it is a smart profiler for Rails apps. Skylight makes it easy to pinpoint performance issues in Rails applications.
We work on a lot of open source projects ourselves, and in our experience it can be pretty hard to get contributors to work on application performance issues. Few contributors consider working on performance problems, and the ones that might be interested may not even know where to start. By making performance information more accessible, we hope to inspire potential contributors to tackle slow parts of your app, and have a good way to see if their contributions helped.
Once this patch is merged and deloyed*, you will be able to view the performance data we collected at the public Skylight dashboard. The dashboard will be accessible to anyone (no Skylight account required) to make it easy for contributors.
(*Actually, I lied a little. We still need to set the
SKYLIGHT_AUTHENTICATIONenvironment variable to the appropiate API key on production, but I will work with @coopdevs on that off-thread.)