enhance: Error groups and handle graceful shutdowns #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenceJJones
commented
Oct 19, 2024
| if err := srv.Shutdown(ctx); err != nil { | ||
| log.Fatal(err) // failure/timeout shutting down the server gracefully | ||
| } | ||
| select { |
There was a problem hiding this comment.
This can be removed or adapted, as this is only the case when the shutdown context is not completed within 5 seconds.
|
I will invest some time tomorrow, to see if I can move the panic recovery as that is also inside a go routine so that needs to be also handled |
Nevermind, it was defer function my bed time reading eyes saw it as a go routine 😆 so this should be handled, since its a IIF call it should be handled by the upper context. |
|
Thank you! I tested it and it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to handle system signals across the whole process rather than a push section (unless there a reason for this 😓 ):
I know this is experimental and I havent had to chance to live test these changes, but this will allow the process to actually respond correctly to system signals and not cause docker / system to force kill the container if the system is wanting to shutdown.