Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service: Shelve #4232

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

Add service: Shelve #4232

wants to merge 5 commits into from

Conversation

HugoRCD
Copy link

@HugoRCD HugoRCD commented Nov 10, 2024

Changes

  • Add Shelve service

link of the service -> https://shelve.cloud
repo of the service -> https://github.com/HugoRCD/shelve

@HugoRCD HugoRCD changed the title Template/shelve Add service: Shelve Nov 10, 2024
@peaklabs-dev peaklabs-dev added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Nov 10, 2024
@peaklabs-dev
Copy link
Member

Please use https://coolify.io/docs/knowledge-base/docker/compose#coolifys-magic-environment-variables for the secrets if they should be random and also add FQDN to create a domain accessible via the proxy

@peaklabs-dev peaklabs-dev added the 💤 Waiting for feedback Issues awaiting a response from the author. label Nov 12, 2024
@HugoRCD
Copy link
Author

HugoRCD commented Nov 12, 2024

I've already looked at the 'magic-environment-variables' and I don't think any are necessary for my installation 🤔 @peaklabs-dev

@peaklabs-dev
Copy link
Member

peaklabs-dev commented Nov 12, 2024

They are how would you access your app on port 3000 and should the NUXT_PRIVATE_ENCRYPTION_KEY and PASSWORD not be autogenerated?

@HugoRCD
Copy link
Author

HugoRCD commented Nov 12, 2024

They are how would you access your app on port 3000 and should the NUXT_PRIVATE_ENCRYPTION_KEY and PASSWORD not be autogenerated?

I consider this variable to be 'critical' and therefore must be filled in by the user, just like the variables for the github and google oauth 🤔 however, as for how the app will be accessed via port 3000, isn't this done via the docker-compose header? since I specified 3000 and the container only exposes port 3000.

@peaklabs-dev
Copy link
Member

peaklabs-dev commented Nov 12, 2024

No, all secret vars should be auto-generated it uses secure function in the background so it is perfect for critical stuff, the port comment will probably be removed soon, all handled by the Coolify magic envs - you need something like SERVICE_SHELVE_FQDN_3000 in the envs as well.

@HugoRCD
Copy link
Author

HugoRCD commented Nov 12, 2024

No, all secret vars should be auto-generated it uses secure function in the background so it is perfect for critical stuff, the port comment will probably be removed soon, all handled by the Coolify magic envs - you need something like SERVICE_SHELVE_FQDN_3000 in the envs as well.

I've just pushed the desired changes, is this better?

@Bilge
Copy link
Contributor

Bilge commented Nov 12, 2024

82 stars
self-promotion

Shouldn't there be rules against this?

@HugoRCD
Copy link
Author

HugoRCD commented Nov 12, 2024

82 stars
self-promotion

Shouldn't there be rules against this?

I don't quite understand what the problem is?

@Bilge
Copy link
Contributor

Bilge commented Nov 12, 2024

Perpetual maintenance of a service nobody will use other than yourself.

@HugoRCD
Copy link
Author

HugoRCD commented Nov 12, 2024

Perpetual maintenance of a service nobody will use other than yourself.

I'm simply adding a template to the project, which will promote the adoption of my platform and which is already of interest to some people. The Coolify team will have no maintenance to do until proven otherwise.

@Bilge
Copy link
Contributor

Bilge commented Nov 12, 2024

This project should (as soon as possible) start adding automated tests for every service. It is highly irresponsible to keep adding more services sans-tests. It is a large body of work, but that mountain only continues to grow as more services are added. Moreover, even the end-user suffers as a finely curated list is far more valuable to browse than a spaffpile of unpopular guff.

The fact that you have no understanding of the cost of maintenance shows you're not an experienced maintainer.

@peaklabs-dev peaklabs-dev removed the 💤 Waiting for feedback Issues awaiting a response from the author. label Nov 13, 2024
@peaklabs-dev peaklabs-dev self-assigned this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Service Issues requesting or PRs adding/fixing service templates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants