Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code scanning alert #148: Multiplication result converted to larger type #25

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Fix code scanning alert #148: Multiplication result converted to larger type #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Ghidra/Features/Decompiler/src/decompile/cpp/constseq.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ int4 ArraySequence::formByteArray(int4 sz,int4 slot,uint8 rootOff,bool bigEndian
int4 maxEl = used.size() / bigElSize;
int4 count;
for(count=0;count<maxEl;count += 1) {
uint1 val = used[ count * bigElSize ];
uint1 val = used[ static_cast<uint8>(count) * bigElSize ];
if (val != 1) { // Count number of characters not including null terminator
if (val == 2)
count += 1; // Allow a single null terminator
Expand Down
Loading