fix underflow issue

coolbutuseless · May 1, 2024 · 506a608 · 506a608
1 parent 225d641
commit 506a608
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: yyjsonr
 Type: Package
 Title: Fast 'JSON', 'NDJSON' and 'GeoJSON' Parser and Generator 
-Version: 0.1.20.9000
+Version: 0.1.20.9001
 Authors@R: c(
     person("Mike", "Cheng", role = c("aut", "cre", 'cph'), 
     email = "[email protected]"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,9 @@
 
+
+# yyjsonr 0.1.20.9001 2024-05-01
+
+* Fix underflow issue when trying to verbosely report an error at position 0
+
 # yyjsonr 0.1.20.9000 2024-04-12
 
 * Get size of gzipped file in an endian-neutral way. Issue #39

diff --git a/src/R-yyjson-parse.c b/src/R-yyjson-parse.c
@@ -1820,9 +1820,11 @@ void output_verbose_error(const char *str, yyjson_read_err err) {
 
   // Print a "^" to point to the error
   size_t pos = ERR_CONTEXT;
-  pos = err.pos < ERR_CONTEXT ? err.pos - 1 : ERR_CONTEXT;
-  for (unsigned int i = 0; i < pos; i++) {
-    Rprintf(" ");
+  if (err.pos > 0) {
+    pos = err.pos < ERR_CONTEXT ? err.pos - 1 : ERR_CONTEXT;
+    for (unsigned int i = 0; i < pos; i++) {
+      Rprintf(" ");
+    }
   }
   Rprintf("^\n");
 }

diff --git a/tests/testthat/test-bug44-infinite-loop-on-bad-string.R b/tests/testthat/test-bug44-infinite-loop-on-bad-string.R
@@ -0,0 +1,11 @@
+
+
+test_that("Invalid string input should cause error", {
+
+  testthat::capture_output({
+  expect_error({
+    read_json_str("hello")
+  })
+  })
+
+})