-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for including commit pattern #258
add support for including commit pattern #258
Conversation
add support for whitelisting commits for changelog. with the option to make it strict with "--strict-whitelist" to whether include merge commits in the whitelist or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a term other than "whitelist" - perhaps "allowlist"?
I went with "exclude" and "include". |
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
hey man @ljharb , let me know if everything is good for this to get merged, I'll open the next PR as soon as this one gets merged. or if you'd prefer I can open the next PR to be merging into this one? |
@rouzwelt i'm reviewing as an interested user, i'm not a maintainer here. |
@cookpete Hey man, I guess you have already looked into this PR, so I was wondering what would be the next steps? Im hoping this can get merged if all looks ok from your side? |
@cookpete hey man, I hope I can get a response from you regarding this PR, please let me know your thoughts about this, Im really hoping this Pr can be considered, it is really big feature that I need with this package, and I believe many others might come across needing it as well |
Hey @cookpete , any chance to get a review for this PR? I'd also be interested in helping maintain this if necessary. |
thanks man for the support, let's wait and see what @cookpete thinks about this, he seems busy :D |
Thanks @rouzwelt for the PR and @ljharb for the review. I’ve simplified the logic and renamed the option to I’ve also allowed both Sorry for the delay! Will publish a new version shortly after I’ve skimmed through the other issues and PRs. |
awesome man, thank you so much 🙏🏻 |
Epic! Thanks! |
I checked and 2.4.0 does not have the option yet. Is there a reason why its not yet published? |
Because I forgot to publish this when I said I would (over a year ago) and then life got very busy. Published in |
thanks ! |
proposing to add support for including commits pattern for changelog. with the option to make it strict with "--strict-include" to whether include merge commits or not.
if the strict flag is provided then only include based on provided regex, else include merge commits as well.