add --sort-tags

[anatawa12]

Closes #197

[ljharb]

Any tests and documentation of the new flag?

[anatawa12]

tests

Sorry, not yet. I'll write test soon

documentation

there's documentation on the source code for --help. I'll copy onto README soon. iPadから送信

…

2021/06/14 12:23、Jordan Harband ***@***.***>のメール:  Any tests and documentation of the new flag? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[anatawa12]

I've added tests and documentation.

[anatawa12]

The implementation is done. If the development team think test for this is enough, This pull request is ready to merge. This PR is approved so I think ready to merge.

[mrttrifork]

What is the status on this PR?

We follow semver, but 2.9.0 appears before 2.10.0, so you get the sense that 2.9.0 is a newer tag.

[anatawa12]

@mrttrifork As I wrote in previous comment, I think it's ready to merge.
@cookpete How do you feel this PR?

[ljharb]

That’s absurd; 8 months isn’t “dormant”.

[cookpete]

I have every intention of catching up with this and react-player when I can, but life tends to gets busier as you get older. Spare time for open source projects becomes very rare.

Regardless, isn’t this whole PR made redundant by the --append-git-tag option? You can add anything you want to the git tag call without the need for yet another new setting.

auto-changelog --append-git-tag "--sort=whatever"

[anatawa12]

Regardless, isn’t this whole PR made redundant by the --append-git-tag option? You can add anything you want to the git tag call without the need for yet another new setting.

I don't think so because the auto-changelog sorts tags by semver after git tag command.

[cookpete]

Good point @anatawa12. In that case I would rather just look for "--sort" inside options.appendGitTag and not sort the tags if it exists.

I’m still trying to understand the use case here? How else would you want to sort your tags?