Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update commits.js #179

Closed
wants to merge 4 commits into from
Closed

Update commits.js #179

wants to merge 4 commits into from
+2 −1

Conversation

kivervinicius
Copy link

Fix problem when match is null

@kivervinicius
Update commits.js
0700349 
Fix problem when match is null
@kivervinicius kivervinicius mentioned this pull request Oct 21, 2020
Closed
ljharb
ljharb reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume this should have a regression test

src/commits.js Outdated Show resolved Hide resolved
src/commits.js Outdated Show resolved Hide resolved
kivervinicius and others added 2 commits October 21, 2020 14:18
@kivervinicius @ljharb
Update src/commits.js
7169531 
Co-authored-by: Jordan Harband <[email protected]>
@kivervinicius @ljharb
Update src/commits.js
6e9ec4d 
Co-authored-by: Jordan Harband <[email protected]>
kivervinicius
kivervinicius commented Oct 21, 2020
View reviewed changes
Copy link
Author

@kivervinicius kivervinicius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@cookpete cookpete closed this in 2bdc772 May 23, 2021
@kivervinicius
Copy link
Author

? Why no merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kivervinicius @ljharb