Specify utensils as a development dependency

[ollieh-m]

What

Remove helpers/have_hash_matcher.rb and instead use the have_hash matcher defined in the utensils gem.

Why

As of this change, utensils includes a have_hash matcher which has a fix when have_hash is used in some js specs (see cookpad/utensils#1 for an explanation).

Currently, we could end up using the wrong version of have_hash in global-web if we require streamy/helpers/rspec_helper after requiring utensils/have_hash_matcher. This PR removes the divergent matcher - there's now only a single, correct have_hash matcher used in all contexts, so no risk of ending up with the wrong one 😅.

How

I've added utensils as a development dependency in the .gemspec. It's not possible to specify the github repo for the dependency in the .gemspec, so I've also added the gem to the regular gemfile - this means when running the gem locally, the cookpad/utensils version of the gem is used, which is the version that has have_hash.

I've googled around but can't see any way to specify a particular source for a gem as part of the gem's dependencies. Please let me know if you can see a way I'm missing 😄.

Anything else

The final step will be to update the streamy gem in global-web.

[Bodacious]

LGTM @ollieh-m

Any thoughts on publishing a forked version of the gem to Rubygems? (e.g. cookpad-utensils) That will give us more control over changes we make to the gem over time.

[balvig]

@ollieh-m @Bodacious Hello from the ghost of Christmas past! 👻

I suppose it's not a big deal either way, but just wanted to say that I'm happy to hand over the 🔑 to utensils including the gem on Rubygems.

As you can tell from my shoddy attempt at coming up with a cooking-related name 😅 , the gem was always intended for Cookpad usage and parity across Cookpad projects.

I think it probably ended up at balvig/utensils simply because that was easier to do at the time...? 🤦

So yeh, let me know what you prefer and we can set up something! 🙏

[Bodacious]

Hi @balvig! It's nice to bump into you here 👋

If you're happy to, I think it would be a good idea if we were able to have at least joint ownership of the gem, so that we didn't have to maintain our own separate fork. 🙇‍♂️

FWIW, I think the name is grand!

[balvig]

👍 let me know who to add as an owner (rubygems email/handle) and I'll set it up :)

[ollieh-m]

🤦‍♂️ Well this fell off my radar.

👍 let me know who to add as an owner (rubygems email/handle) and I'll set it up :)

Could you add [email protected]?

And to clarify, will we be able to make the current fork (at cookpad/utensils) the utensils gem? We don't need to create a new gem right?

🙇‍♂️

[Bodacious]

And to clarify, will we be able to make the current fork (at cookpad/utensils) the utensils gem? We don't need to create a new gem right?

As long as you have write access on Rubygems, you should be able to publish new versions from the fork without having to cut a new gem 🤓

[balvig]

@ollieh-m you should be added now!