Migrate CI to Github Actions #2931
Conversation
|
Thanks for taking a look. I -and all core contributors- can commit directly to master as well. |
|
@browniebroke Why do we need the 46a0b60 change? |
|
|
||
| on: | ||
| push: | ||
| branches: [ master ] |
There was a problem hiding this comment.
| branches: [ master ] | |
| branches: master |
There was a problem hiding this comment.
Does this work? I though this part needs to be an array. I couldn't find an example with a string in the docs... Do you have a working example?
There was a problem hiding this comment.
I have many working examples, but they are all private repos. Anyways this is /nit
I think that is fine. The pull requests CI will be just fine. Plus with |
| tox: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false |
There was a problem hiding this comment.
when don't we need fail fast?
There was a problem hiding this comment.
With fail-fast the whole job would be interrupted as soon as one of the subjobs fails. In my experience it's nicer to get both to run entirely to get all failures reported as opposed to only the first failure.
| - name: Tox ${{ matrix.tox-env }} | ||
| run: tox -e ${{ matrix.tox-env }} | ||
|
|
||
| docker: |
There was a problem hiding this comment.
why not just directly translate from travis by using matrix for docker and bare metal?
There was a problem hiding this comment.
Right now, I could probably merge the docker and tox jobs, but I'm hoping that we could speed up each job leter by adding some specialised caching.
The bare metal job requires some extra services that the other jobs don't use.
|
I've recently moved 20+ repos from Travis CI to Github Action for my organization, let me know if you need help with this PR |
|
@luzfcb Pyup uses several branches itself in this repository. That would mean pyup is running the CI in a branch here and in a PR. I'm not entirely sure why the CI isn't working on your PRs, but I suspect it's because actions aren't run on forks. As you may see, this PR is built on a branch from this repo. |
Hum, that's really odd. I was trying to avoid the duplicated status that you have in luzfcb#5 where each job run twice, once for the
I suspect too, but again, it's strange that both run fine in the other case... |
Description
Migrate CI to Github Actions cc @Andrew-Chen-Wang @arnav13081994
Checklist:
tests/test_cookiecutter_generation.pyis updated accordingly (especially if adding or updating a template option)This doesn't aim at adding any sort of caching but just to keep feature parity with Travis for now.
Rationale
Travis recently changed their pricing with hard limits to open source projects, Github actions have a higher allowace at the moment.
Fixes #2928