Add dedicated websockets package #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: encode/uvicorn#797 There used to be a package automatically installed; not anymore I guess. This came from a separate package and not cookiecutter-django, but the installation was similar.
browniebroke
approved these changes
Oct 8, 2020
| @@ -25,6 +25,7 @@ flower==0.9.5 # https://github.com/mher/flower | |||
| {%- endif %} | |||
| {%- if cookiecutter.use_async == 'y' %} | |||
| uvicorn==0.12.1 # https://github.com/encode/uvicorn | |||
| wsproto==0.15.0 # https://github.com/python-hyper/wsproto/ | |||
There was a problem hiding this comment.
Good catch, I believe it's because of encode/uvicorn#666. A bit of a shame that there is no extra_require for it from uvicorn. I guess we'll have to pay attention to uvicorn updates in case they remove the integration or provide an extra for it.
Didn't know about this library, looks good.
|
@browniebroke Nice, I couldn't find the PR for this. Anyhow, it may be necessary to add these packages as well: https://github.com/encode/uvicorn/pull/666/files#diff-2eeaed663bd0d25b7e608891384b7298R53-R54 Those used to come with the standard installation of uvicorn. Although, without them, uvicorn seems to be running properly, I somewhat have my doubts for production mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: encode/uvicorn#797
There used to be a package automatically installed; not anymore I guess. This came from a separate package and not cookiecutter-django, but the installation was similar.
Rationale
For websockets to work, you need a package like wsproto or websockets (which is not as maintained). Uvicorn at some point might have dropped the auto installation of one of these packages that made websockets unavailable to work with.