-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Compose development environment #238
Conversation
9d20306
to
ff0c28a
Compare
Hello @martinblech, that sounds good. What will I speak, it is only my opinion, and can not be the same as the rest of the team. First, I'm still trying to understand how the Docker ecosystem works. having said that, I have some questions:
I think some of the answers to these questions should be included in the documentation to avoid problems and wrong interpretations. |
Hello @luzfcb, thank you for your feedback.
Couldn't agree more about "explicit is better than implicit". |
Vagrant support was dropped in favor of Docker based development environments, but no replacement was provided. This should do.
@luzfcb Please look at the comments I just amended to |
While having a development environment powered by compose is neat, I'd go one step further and add a configuration that works for dev and prod. I'd suggest the following:
As of compose
In fact, I've ported a couple of projects that were started with If there's interest in that, I'd be happy to put something together over the next few days. |
The |
I made a PR here #284 It is basically working like @martinblech's contribution for development with a few tweaks (env variables are set automatically in |
Closing as #284 encompasses this excellent work. |
Vagrant support was dropped in favor of Docker based development environments, but no replacement was provided. This should do.