Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX missing parameters in v2.listEntities() documentation #28

Merged
merged 2 commits into from
Sep 25, 2019
Merged

FIX missing parameters in v2.listEntities() documentation #28

merged 2 commits into from
Sep 25, 2019

Conversation

fgalan
Copy link
Contributor

@fgalan fgalan commented Sep 17, 2019

Addresses the documentation gap described in issue #27

The repository has another NGSI.js file in ngsijs/dist/ directory. I haven't touched that one as I don't know what it is :) but if the same change needs to be propagated in it, just tell me.

Please @aarranz review. Thanks!

@coveralls
Copy link

coveralls commented Sep 17, 2019

Coverage Status

Coverage decreased (-2.0%) to 94.015% when pulling 7edb481 on fgalan:patch-1 into f2678de on conwetlab:master.

@fgalan
Copy link
Contributor Author

fgalan commented Sep 17, 2019

Coverage decreased (-5.3%) to 90.69% when pulling c2ac37c on fgalan:patch-1 into f2678de on conwetlab:master.

I haven't touched a single line of real code. Maybe the coverage reporter should be configured to not take into account comments? ;)

@aarranz aarranz merged commit b53903a into conwetlab:master Sep 25, 2019
@aarranz
Copy link
Member

aarranz commented Sep 25, 2019

Hi @fgalan!

First, thank you very much for the contribution.

The repository has another NGSI.js file in ngsijs/dist/ directory. I haven't touched that one as I don't know what it is :) but if the same change needs to be propagated in it, just tell me.

The NGSI.js file inside the ngsijs/dist/ directory is the latest released stable version. So your changes will be propagated into that file just after we make a new release.

Coverage decreased (-5.3%) to 90.69% when pulling c2ac37c on fgalan:patch-1 into f2678de on conwetlab:master.

I haven't touched a single line of real code. Maybe the coverage reporter should be configured to not take into account comments? ;)

Coveralls is already ignoring code comments, but I have found the problem. It was related to one travis jobs failing to start xvfb (it seems that has something has been changed on the Travis side). I've added a commit into your PR and now coverage is fine (although coveralls still reports an invalid coverage value for the PR).

Taking that into account, I have merged your changes 😃.

@fgalan fgalan deleted the patch-1 branch September 25, 2019 18:15
@fgalan
Copy link
Contributor Author

fgalan commented Sep 25, 2019

You're welcome! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants