Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource websocket proxy #3740

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix resource websocket proxy #3740

merged 1 commit into from
Sep 9, 2024

Conversation

nightfury1204
Copy link
Collaborator

@nightfury1204 nightfury1204 commented Sep 6, 2024

What is the feature/fix?

Fix: Improve Resource Proxy for Large File Dump/Restore Operations

This update improves the resource proxy to handle large file dump and restore operations in v2. Previously, when using convox resources proxy for locally proxied resources, sessions would disconnect during large data operations. With this fix, Convox resource databases can now handle larger operations reliably, ensuring stable connections throughout the process.

Why is this important?

Before this fix, users attempting to run large database dumps or restores over a proxied resource would often experience session disconnections, limiting the ability to manage large datasets in local development environments. This update resolves the issue, allowing stable connections for larger data transfers through the proxy.

Does it have a breaking change?

There are no breaking changes introduced with this fix.

How to use/test it?

  1. Update your rack to version 20240909145100 or later:

    $ convox rack update -r rackName
    
  2. Proxy the resource and test by running large file dump or restore operations:

    • Example of proxying a Postgres resource:
    $ convox resources proxy mydb
    Proxying localhost:5432 to mydb-0001.internal.postgres.amazonaws.com
    
    • To dump the database:
    $ pg_dump -h localhost -p 5432 -U mydb_user -d mydb_name > backup.sql
    
    • To restore a database:
    $ psql -h localhost -p 5432 -U mydb_user -d mydb_name < backup.sql
    

    The session should remain stable throughout the operation.

Requirements

To use this fix, you must be on at least rack version 20240909145100.
You can check your rack's version with the command convox rack -r rackName.
Update your rack to the latest version with the command convox rack update -r rackName.

@nightfury1204 nightfury1204 merged commit e880d54 into master Sep 9, 2024
6 of 8 checks passed
@nightfury1204 nightfury1204 deleted the proxy-fix branch September 9, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant