Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Export build git sha #3688

Closed
wants to merge 1 commit into from
Closed

Conversation

nightfury1204
Copy link
Collaborator

What is the feature/fix?

https://app.asana.com/0/1203637156732418/1204875717950149/f

Add screenshot or video (optional)

** Any screenshot or video capture using the feature **

Does it has a breaking change?

** Describe the changes and if it has any breaking changes in any feature **

How to use/test it?

  • you need cli and rack of this version

Checklist

  • New coverage tests
  • Unit tests passing
  • E2E tests passing
  • E2E downgrade/update test passing
  • Documentation updated
  • No warnings or errors on Deepsource/Codecov

@nightfury1204 nightfury1204 force-pushed the feat-git-build-sha branch 2 times, most recently from 0c8de6c to 629db69 Compare June 30, 2023 20:31
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 58.33% and project coverage change: +0.05 🎉

Comparison is base (fcb6894) 35.78% compared to head (8aafec5) 35.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3688      +/-   ##
==========================================
+ Coverage   35.78%   35.83%   +0.05%     
==========================================
  Files         169      169              
  Lines       18719    18731      +12     
==========================================
+ Hits         6699     6713      +14     
+ Misses      10882    10879       -3     
- Partials     1138     1139       +1     
Impacted Files Coverage Δ
provider/aws/builds.go 18.03% <20.00%> (+0.01%) ⬆️
provider/aws/processes.go 46.11% <50.00%> (+<0.01%) ⬆️
pkg/cli/builds.go 73.17% <100.00%> (+0.67%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

nightfury1204 added a commit that referenced this pull request Jul 3, 2023
### What is the feature/fix?

https://app.asana.com/0/1203637156732418/1204875717950149/f

### Add screenshot or video (optional)

** Any screenshot or video capture using the feature **

### Does it has a breaking change?

** Describe the changes and if it has any breaking changes in any feature **

### How to use/test it?

- you need cli and rack of this version

### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
@nightfury1204 nightfury1204 mentioned this pull request Jul 3, 2023
4 tasks
nightfury1204 added a commit that referenced this pull request Jul 4, 2023
### What is the feature/fix?

https://app.asana.com/0/1203637156732418/1204875717950149/f

### Add screenshot or video (optional)

** Any screenshot or video capture using the feature **

### Does it has a breaking change?

** Describe the changes and if it has any breaking changes in any feature **

### How to use/test it?

- you need cli and rack of this version

### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
@nightfury1204 nightfury1204 deleted the feat-git-build-sha branch July 10, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant