[RELEASE] 20230516 #3678
Merged
[RELEASE] 20230516 #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3678 +/- ##
==========================================
- Coverage 36.04% 35.82% -0.23%
==========================================
Files 168 169 +1
Lines 18536 18719 +183
==========================================
+ Hits 6682 6706 +24
- Misses 10717 10874 +157
- Partials 1137 1139 +2
☔ View full report in Codecov by Sentry. |
### What is the feature/fix? AWS is deprecating the Launch Configuration, they recommend using the Launch Configuration. New instances types are not being added to launch config, only to launch templates. ### Does it has a breaking change? No, all features of Launch Config are available on Launch Template. ### How to use/test it? 1. Install the RC on a rack 2. Deploy a new app and use it You can also set SpotInstanceBid and check if the instances are being created. ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
…service ### What is the feature/fix? Service has an option to set if it should receive privileged access. > When this parameter is true, the container is given elevated privileges on the host container instance (similar to the root user). This parameter maps to Privileged in the [Create a container](https://docs.docker.com/engine/api/v1.35/#operation/ContainerCreate) section of the [Docker Remote API](https://docs.docker.com/engine/api/v1.35/) and the --privileged option to [docker run](https://docs.docker.com/engine/reference/run/#security-configuration). Set privileged option on container definition when it's set on service. ### Does it has a breaking change? No ### How to use/test it? - Update/install the RC in a rack - Deploy a service with `privileged` set to true and a timer linking the service. - Look at the container definition, on ECS, and you should see Privileged as true. ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
### What is the feature/fix? When HighAvailability is set to false, the autoscale will maintain a certain number of extra capacity instances running on racks that are not configured for high availability ### Does it has a breaking change? No ### How to use/test it? ** Describe how to test or use the feature ** ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
### What is the feature/fix? The resource `memcached` does not have a default scheme, and when the CLI tries to parse the URL it fails. Only when the resource doesn't have the scheme, it will prepend `https://` to it so the parse can be done correctly. The `https://` is just a mock, it will not be used by the proxy. However in other cases, the resources already have a default scheme, so we don't need to prepend anything. ### Add screenshot or video (optional) ``` $ ./convox resources proxy memcached -r company/test-v2 -a nodejs resourceUrl: https://tes-ca-a9w1wj3z6inb.ggqx34.cfg.use1.cache.amazonaws.com:11211 proxying localhost:11211 to tes-ca-a9w1wj3z6inb.ggqx34.cfg.use1.cache.amazonaws.com:11211 ^C $ ./convox resources proxy db -r company/test-v2 -a nodejs resourceUrl: mysql://app:9da1d8b0-e918-11ed-85a0-0e0742ca01a9@test-v2-nodejs-resourcedb-dxaplp4g31i7.crsmvbsswb2b.us-east-1.rds.amazonaws.com:3306/app proxying localhost:3306 to test-v2-nodejs-resourcedb-dxaplp4g31i7.crsmvbsswb2b.us-east-1.rds.amazonaws.com:3306 ^C $ ./convox resources proxy postgres -r company/test-v2 -a nodejs resourceUrl: postgres://app:9da1d8b0-e918-11ed-85a0-0e0742ca01a9@test-v2-nodejs-resourcepostgres-no8wpe8bxfby.crsmvbsswb2b.us-east-1.rds.amazonaws.com:5432/app proxying localhost:5432 to test-v2-nodejs-resourcepostgres-no8wpe8bxfby.crsmvbsswb2b.us-east-1.rds.amazonaws.com:5432 ^C ``` ### Does it has a breaking change? No ### How to use/test it? - Create a rack and deplot an app with mysql, memcached and postgres resource - Run `convox resources proxy` as showed above. ### Checklist - [x] New coverage tests - [x] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
### What is the feature/fix? https://app.asana.com/0/1203637156732418/1204423756010922/f ### Add screenshot or video (optional) ### Does it has a breaking change? no ### How to use/test it? ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
ntner
approved these changes
May 23, 2023
There was a problem hiding this comment.
- Install and update to rack version
- Downgrade to previous version
- Telemetry based param groupings at install
- Common convox rack param set variations after install
- New application install and running with multiple resources
- Existing application working after upgrade
- Review and Deploy Workflows working across update
- General and build stress-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests
Milestone Release