Create new Api Policy with the missing permissions #3667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Twsouza
added a commit
that referenced
this pull request
Apr 25, 2023
### What is the feature/fix?
Add the missing permissions for Api Policy as `ApiPolicyV2`. The old api policy does not have the permission to create new policy versions, but it has to create new policies.
### Does it has a breaking change?
No.
### How to use/test it?
Run `convox rack update {RC}` on a rack with [20230322142551](https://github.com/convox/rack/releases/tag/untagged-c577a03c5528a0a4fac6) or [20230302000800](https://github.com/convox/rack/releases/tag/untagged-cf57ff8ae32778585073).
### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
Twsouza
added a commit
that referenced
this pull request
Apr 25, 2023
### What is the feature/fix?
Add the missing permissions for Api Policy as `ApiPolicyV2`. The old api policy does not have the permission to create new policy versions, but it has to create new policies.
### Does it has a breaking change?
No.
### How to use/test it?
Run `convox rack update {RC}` on a rack with [20230322142551](https://github.com/convox/rack/releases/tag/untagged-c577a03c5528a0a4fac6) or [20230302000800](https://github.com/convox/rack/releases/tag/untagged-cf57ff8ae32778585073).
### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
Twsouza
added a commit
that referenced
this pull request
Apr 26, 2023
### What is the feature/fix?
Add the missing permissions for Api Policy as `ApiPolicyV2`. The old api policy does not have the permission to create new policy versions, but it has to create new policies.
### Does it has a breaking change?
No.
### How to use/test it?
Run `convox rack update {RC}` on a rack with [20230322142551](https://github.com/convox/rack/releases/tag/untagged-c577a03c5528a0a4fac6) or [20230302000800](https://github.com/convox/rack/releases/tag/untagged-cf57ff8ae32778585073).
### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
Twsouza
added a commit
that referenced
this pull request
Apr 26, 2023
### What is the feature/fix?
Add the missing permissions for Api Policy as `ApiPolicyV2`. The old api policy does not have the permission to create new policy versions, but it has to create new policies.
### Does it has a breaking change?
No.
### How to use/test it?
Run `convox rack update {RC}` on a rack with [20230322142551](https://github.com/convox/rack/releases/tag/untagged-c577a03c5528a0a4fac6) or [20230302000800](https://github.com/convox/rack/releases/tag/untagged-cf57ff8ae32778585073).
### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
Twsouza
added a commit
that referenced
this pull request
Apr 27, 2023
### What is the feature/fix?
Add the missing permissions for Api Policy as `ApiPolicyV2`. The old api policy does not have the permission to create new policy versions, but it has to create new policies.
### Does it has a breaking change?
No.
### How to use/test it?
Run `convox rack update {RC}` on a rack with [20230322142551](https://github.com/convox/rack/releases/tag/untagged-c577a03c5528a0a4fac6) or [20230302000800](https://github.com/convox/rack/releases/tag/untagged-cf57ff8ae32778585073).
### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
Add the missing permissions for Api Policy as
ApiPolicyV2. The old api policy does not have the permission to create new policy versions, but it has to create new policies.Does it has a breaking change?
No.
How to use/test it?
Run
convox rack update {RC}on a rack with 20230322142551 or 20230302000800.Checklist