Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli for attaching runtime integrations #3652

Closed
wants to merge 1 commit into from

Conversation

nightfury1204
Copy link
Collaborator

What is the feature/fix?

https://app.asana.com/0/1203637156732418/1204034844054250/f

Add screenshot or video (optional)

Does it has a breaking change?

no

How to use/test it?

Checklist

  • New coverage tests
  • Unit tests passing
  • E2E tests passing
  • E2E downgrade/update test passing
  • Documentation updated
  • No warnings or errors on Deepsource/Codecov

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 13.55% and project coverage change: -0.08 ⚠️

Comparison is base (5b5011c) 36.01% compared to head (d6d7cde) 35.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3652      +/-   ##
==========================================
- Coverage   36.01%   35.94%   -0.08%     
==========================================
  Files         168      168              
  Lines       18585    18644      +59     
==========================================
+ Hits         6694     6702       +8     
- Misses      10751    10802      +51     
  Partials     1140     1140              
Impacted Files Coverage Δ
sdk/methods.go 76.52% <0.00%> (-1.95%) ⬇️
pkg/cli/rack.go 58.20% <17.39%> (-6.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nightfury1204 nightfury1204 added this to the 20230308 milestone Mar 8, 2023
nightfury1204 added a commit that referenced this pull request Mar 8, 2023
### What is the feature/fix?

https://app.asana.com/0/1203637156732418/1204034844054250/f

### Add screenshot or video (optional)

### Does it has a breaking change?

no

### How to use/test it?

- deploy the console: convox/console#312
- then deploy rack and try the cli

### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
@nightfury1204 nightfury1204 mentioned this pull request Mar 8, 2023
10 tasks
@Twsouza Twsouza modified the milestones: 20230308, 20230321 Mar 21, 2023
Twsouza added a commit that referenced this pull request Mar 21, 2023
### What is the feature/fix?

https://app.asana.com/0/1203637156732418/1204034844054250/f

### Add screenshot or video (optional)

### Does it has a breaking change?

no

### How to use/test it?

- deploy the console: https://github.com/convox/console/pull/312
- then deploy rack and try the cli

### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
@Twsouza Twsouza mentioned this pull request Mar 21, 2023
10 tasks
Twsouza added a commit that referenced this pull request Mar 22, 2023
### What is the feature/fix?

https://app.asana.com/0/1203637156732418/1204034844054250/f

### Add screenshot or video (optional)

### Does it has a breaking change?

no

### How to use/test it?

- deploy the console: https://github.com/convox/console/pull/312
- then deploy rack and try the cli

### Checklist
- [ ] New coverage tests
- [ ] Unit tests passing
- [ ] E2E tests passing
- [ ] E2E downgrade/update test passing
- [ ] Documentation updated
- [ ] No warnings or errors on Deepsource/Codecov
@nightfury1204 nightfury1204 deleted the feat-runtime-attach branch August 29, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants