Save racks installed locally through the CLI #3631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 36.04% // Head: 36.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3631 +/- ##
==========================================
- Coverage 36.04% 36.01% -0.04%
==========================================
Files 168 168
Lines 18536 18585 +49
==========================================
+ Hits 6682 6694 +12
- Misses 10717 10751 +34
- Partials 1137 1140 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Depends on convox/stdcli#4 |
|
I'm waiting for the stdcli PR to be merge so I can update this PR to include the changes. |
|
stdcli package is updated |
Twsouza
force-pushed
the
fix-818-cli-rack-install
branch
from
3ec02be
to
78303b8
Compare
Twsouza
changed the title
yuriadams
approved these changes
Feb 6, 2023
nightfury1204
approved these changes
Feb 6, 2023
Twsouza
added a commit
that referenced
this pull request
Feb 6, 2023
### What is the feature/fix? When a rack is installed using the CLI locally, not through the console or local rack, the installation finishes but don't keep the rack host anywhere. The CLI now will store the racks installed through it in the `self-managed` file. ### Does it has a breaking change? No, however past racks installed using the CLI won't be recoverable, only if the user creates the rack entry on `self-managed`. ### How to use/test it? 1. Login into a console (e.g. console.convox.com) 2. Install the rack through the RC CLI (to be created). 3. Check if the rack is listed on `convox racks` 4. Switch to the new rack 5. Uninstall it 6. Run `convox racks` and the rack should not be on the list ### Checklist - [x] New coverage tests - [x] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
Twsouza
added a commit
that referenced
this pull request
Feb 6, 2023
### What is the feature/fix? When a rack is installed using the CLI locally, not through the console or local rack, the installation finishes but don't keep the rack host anywhere. The CLI now will store the racks installed through it in the `self-managed` file. ### Does it has a breaking change? No, however past racks installed using the CLI won't be recoverable, only if the user creates the rack entry on `self-managed`. ### How to use/test it? 1. Login into a console (e.g. console.convox.com) 2. Install the rack through the RC CLI (to be created). 3. Check if the rack is listed on `convox racks` 4. Switch to the new rack 5. Uninstall it 6. Run `convox racks` and the rack should not be on the list ### Checklist - [x] New coverage tests - [x] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
Twsouza
added a commit
that referenced
this pull request
Feb 7, 2023
### What is the feature/fix? When a rack is installed using the CLI locally, not through the console or local rack, the installation finishes but don't keep the rack host anywhere. The CLI now will store the racks installed through it in the `self-managed` file. ### Does it has a breaking change? No, however past racks installed using the CLI won't be recoverable, only if the user creates the rack entry on `self-managed`. ### How to use/test it? 1. Login into a console (e.g. console.convox.com) 2. Install the rack through the RC CLI (to be created). 3. Check if the rack is listed on `convox racks` 4. Switch to the new rack 5. Uninstall it 6. Run `convox racks` and the rack should not be on the list ### Checklist - [x] New coverage tests - [x] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
When a rack is installed using the CLI locally, not through the console or local rack, the installation finishes but don't keep the rack host anywhere. The CLI now will store the racks installed through it in the
self-managedfile.Does it has a breaking change?
No, however past racks installed using the CLI won't be recoverable, only if the user creates the rack entry on
self-managed.How to use/test it?
convox racksconvox racksand the rack should not be on the listChecklist