-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Towards Log Subscription Perfection #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ety; prepare for CLIENT_ID
…ze NewMonitor logs
nzoschke
changed the title
WIP: Refactor towards Log Subscription perfection
Refactor towards Log Subscription perfection
Apr 20, 2016
nzoschke
changed the title
Refactor towards Log Subscription perfection
Refactor Towards Log Subscription Perfection
Apr 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is available for testing with
convox rack update 20160420210148-agent-0.68
Paired up with @awsmsrc to lick the problem where log the subscribers failed and never recovered, taking individual process logs offline until a restart.
This is a release candidate, though we could consider dialing down logs a bit before releasing this. I'll make a judgement call after some production instance hours.