Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Towards Log Subscription Perfection #22

Merged
merged 17 commits into from
Apr 25, 2016
Merged

Refactor Towards Log Subscription Perfection #22

merged 17 commits into from
Apr 25, 2016

Conversation

nzoschke
Copy link
Contributor

@nzoschke nzoschke commented Apr 20, 2016

This is available for testing with convox rack update 20160420210148-agent-0.68

Paired up with @awsmsrc to lick the problem where log the subscribers failed and never recovered, taking individual process logs offline until a restart.

  • Refactor/rewrite subscribeLogs with much better Go concurrency and synchronization patterns
  • Log with metrics around lines read from Docker (metric: Lines)
  • Instrument, and log with metrics around events written to CloudWatch (metric: CloudWatchEventsSuccesses / CloudWatchEventsErrors)
  • Normalize logging everywhere and add logging to to make it easier to understand in development
  • Send all agent logs to the Rack LogGroup to better understand / debug and visualize in production
  • Stop sending agent logs to the Rack Kinesis

This is a release candidate, though we could consider dialing down logs a bit before releasing this. I'll make a judgement call after some production instance hours.

screen shot 2016-04-20 at 4 08 53 pm

@nzoschke nzoschke changed the title WIP: Refactor towards Log Subscription perfection Refactor towards Log Subscription perfection Apr 20, 2016
@nzoschke nzoschke changed the title Refactor towards Log Subscription perfection Refactor Towards Log Subscription Perfection Apr 20, 2016
@nzoschke nzoschke merged commit 6293c09 into master Apr 25, 2016
@nzoschke nzoschke deleted the refactor branch April 25, 2016 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant