Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed a bit when removing connect which was... quite important! (the part where it attaches to the server...)
Fortunately we can make use of express 4.x no longer needing/depending on connect and just attach to it directly.
To test this locally you can just fire up the
./bin/exampleserver
, but the tests cover it as well (most of them have changed to use the plain express option, as I just deleted the method ShareJS had for creating it's own http server).