Conversant adapter: use ortbConverter to handle requests and responses #14

johnwier · 2023-11-29T17:51:16Z

Type of change

Bugfix
[ X] Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

Migrate the Conversant bid adapter to use the ortbConverter library

Other information

AaronColbyPrice · 2023-11-29T19:03:28Z

LGTM

* Missena Bid Adapter: add capping support * Switch to safeJSONParse * Update tests to cover capping

…10646) - invalid ad units are put into a voidAuIds array from the ad server. - this stores those ad units into local storage and prevents calling to those ad units. - also handles any values from metaData from the adserver response.

* TPMN Support Video * add video param plcmt * update ortb bcat,badv,bapp * instream video is sound on default, outstream video sound off default * remove VIDEO_ORTB_PARAMS, BANNER_ORTB_PARAMS * fixed incorrect placement default format & update example * update test case (Your tests failed on CircleCI) * Revert "remove VIDEO_ORTB_PARAMS, BANNER_ORTB_PARAMS" This reverts commit 2699115. * Remove unnecessary code to meet guidelines. * Remove unnecessary code to meet guidelines. * fix Build fail * delete logging code * Remove OptionsObject(Credentials information needs to be sent.) --------- Co-authored-by: changjun <[email protected]> Co-authored-by: yeongjaeju <[email protected]>

* Add dynamicAdBoost Module * Add dynamicAdBoost spec file * dynamicAdBoost: fix ES Lint * dynamicAdBoost: ESLint fix * dynamicAdBoost: ESLint fix * dynamicAdBoost: fix ESLint * dynamicAdBoost: removed unused log warn * dynamicAdBoost: Fixed tests * dynamicAdBoost: export init() function * Delete dynamicAdBoost.md * Delete dynamicAdBoost.js * Delete dynamicAdBoost_spec.js * Rename dynamicAdBoost to dynamicAdBoostRtdProvider dynamicAdBoost is now submodule of the rtd * dynamicAdBoost tests * Added disconnect() and IO support check * dynamicAdBoostRtdProvider: markViewad added * dynamicAdBoostRtdProvider: markViewed added * dynamicAdBoostRtdProvider.js: observer fix * dynamicAdBoostRtdProvider.js: observer fix * dynamicAdBoostRtdProvider.js: ESLint fix * dynamicAdBoostRtdProvider.js: var to let * dynamicAdBoostRtdProvider.js: moved timers * dynamicAdBoostRtdProvider_spec.js: using clock * dynamicAdBoostRtdProvider_spec.js: fakeTimer * Update adloader.js Adding dynamicAdBoost module to approved list

* Flipp Bid Adapter: initial release * Added flippBidAdapter * OFF-372 Support DTX/Hero in flippBidAdapter (#2) * support creativeType * OFF-422 flippBidAdapter handle AdTypes --------- Co-authored-by: Jairo Panduro <[email protected]> * OFF-465 Add getUserKey logic to prebid.js adapter (#3) * Support cookie sync and uid * address pr feedback * remove redundant check * OFF-500 Support "startCompact" param for Prebid.JS #4 * set startCompact default value (#5) * fix docs * use client bidding endpoint * update unit testing endpoint * OFF-876 [Prebid Adapter] Check userKey for empty string (#6) * add more checks to userKey * update document * add uuid format statement * modify docs * fix network id --------- Co-authored-by: Jairo Panduro <[email protected]>

…in 3p call (prebid#10778)

* Add EID translation for sovrn * Review comments: fix test

pycnvr · 2023-11-30T23:08:17Z

test/spec/modules/conversantBidAdapter_spec.js

-    expect(spec.isBidRequestValid(bidRequests[3])).to.be.true;
-    expect(spec.isBidRequestValid(bidRequests[4])).to.be.true;
-    expect(spec.isBidRequestValid(bidRequests[5])).to.be.true;
+    bidRequests.map((bid) => {


Should be forEach?

That's an easy change

pycnvr · 2023-11-30T23:11:58Z

test/spec/modules/conversantBidAdapter_spec.js

+          w: screen.width,
+          h: screen.height,
+          dnt: 0,
+          ua: navigator.userAgent
        }
      }
    };
    const request = spec.buildRequests(bidRequests, bidderRequest);


These 2 lines (278 and 279) should be placed in either before or beforeEach.

pycnvr · 2023-11-30T23:14:30Z

test/spec/modules/conversantBidAdapter_spec.js

-      transactionId: 'tx001',
-      bidId: 'bid007',
-      bidderRequestId: '117d765b87bed38',
-      auctionId: 'req000'


Is this section removed because it's unused?

yes, it didn't add anything new to the tests anymore

pycnvr · 2023-11-30T23:15:53Z

test/spec/modules/conversantBidAdapter_spec.js

@@ -440,59 +456,59 @@ describe('Conversant adapter tests', function() {
    expect(request.url).to.equal(testUrl);
  });

-  it('Verify interpretResponse', function() {
+  describe('Verify interpretResponse', function() {
+    let bid;
    const request = spec.buildRequests(bidRequests, {});
    const response = spec.interpretResponse(bidResponses, request);


I think the checks are broken up, so these two lines (461 and 462) probably should go into a before().

pycnvr · 2023-11-30T23:41:58Z

modules/conversantBidAdapter.js

+  request: function (buildRequest, imps, bidderRequest, context) {
+    const request = buildRequest(imps, bidderRequest, context);
+    request.at = 1;
+    request.cur = 'USD';


What's the reason for adding currency in the request?

pycnvr · 2023-12-01T17:23:31Z

modules/conversantBidAdapter.js

+      secure: 1,
+      bidfloor: getBidFloor(bidRequest) || 0,
+      displaymanager: 'Prebid.js',
+      displaymanagerver: '$prebid.version$'


I think these should use back tick for substitution.

nope, just single quotes, that's what you see used among other adapters as well

modules/conversantBidAdapter.js

pycnvr · 2023-12-01T17:50:19Z

modules/conversantBidAdapter.js

+    const bidResponse = buildBidResponse(bid, context);
+    return bidResponse;
+  },
+  response(buildResponse, bidResponses, ortbResponse, context) {


This shouldn't be overridden. Instead this code should be moved to interpretResponse.

I don't really want this in interpretResponse because I want ortbConverter to make all the decisions on what is returned. Any decisions I make here may need to be modified if they make any changes in the future.

Ok, let me ask another way. I thought results of overrides should still conform to ORTB structures. What does response do? By returning just the bids portion here, didn't it just break the ORTB structure?

In the README, it's also handled in interpretResponse.

Edit: I realize it's processing the response, so it's not conforming to an ORTB structure, but it's in a Prebid structure, right?

I get it now. You're right, I'll take care of it.

pycnvr · 2023-12-01T18:06:37Z

modules/conversantBidAdapter.js

+        imp.video = mergeDeep(videoData, imp.video);
+        fillVideoImp(imp, bidRequest, context);
+      },
+      bidfloor(setBidFloor, imp, bidRequest, context) {


Not sure if this is needed since imp at line 89 already sets the floor.

It's leftover from when I was looking at their floor module. I'll remove it.

pycnvr · 2023-12-01T18:14:24Z

modules/conversantBidAdapter.js

-    let siteId = '';
-    let pubcid = null;
-    let pubcidName = '_pubcid';
+  makeBidUrl: function(bid) {


Maybe move makeBidUrl outside of spec because it's not a part of the interface.

* Unruly Protected Audience Support * Unruly Conditional Protected Audience Support * Unruly map bidIds to AuctionConfigs * Unruly: Update Protected Audience origin and descision logic URL. * Unruly: Fix lint error * Unruly: report Prebid.js version * Unruly: Fix tests * Unruly: Remove Extra Comma * Unruly: Switch to strings to see if tests pass on Prebid.js --------- Co-authored-by: Brian Haines <[email protected]>

) * new adapter - MgidX * add new required param host * Revert "add new required param host" This reverts commit 3bafe78. * refactoring generating request.gdpr object * fix test --------- Co-authored-by: Evgeny Nagorny <[email protected]> Co-authored-by: xmgiddev <>

…ecat`, `site.content.cat` and `site.content.language` (prebid#10761) * added support for gpp consent string * changed test for nextMillenniumBidAdapter * added some tests * added site.pagecat, site.content.cat and site.content.language to request * lint fix * formated code * formated code * formated code * pachage-lock with prebid * pachage-lock with prebid * formatted code

* add Rise adapter * fixes * change param isOrg to org * Rise adapter * change email for rise * fix circle failed * bump * bump * bump * remove space * Upgrade Rise adapter to 5.0 * added isWrapper param * addes is_wrapper parameter to documentation * added is_wrapper to test * removed isWrapper * Rise Bid Adapter: support Coppa param (prebid#24) * MinuteMedia Bid Adapter: support Coppa param (prebid#25) * Revert "MinuteMedia Bid Adapter: support Coppa param (prebid#25)" (prebid#26) This reverts commit 66c4e7b. * bump * update coppa fetch * setting coppa param update * update Coppa tests * update test naming * Rise Bid Adapter: support plcmt and sua (prebid#27) * update minuteMediaBidAdapter - support missing params (prebid#29) * RIseBidAdapter: support currency (prebid#35) --------- Co-authored-by: Noam Tzuberi <[email protected]> Co-authored-by: noamtzu <[email protected]> Co-authored-by: Noam Tzuberi <[email protected]> Co-authored-by: Laslo Chechur <[email protected]> Co-authored-by: OronW <[email protected]> Co-authored-by: lasloche <[email protected]> Co-authored-by: inna <[email protected]> Co-authored-by: YakirLavi <[email protected]>

* add Rise adapter * fixes * change param isOrg to org * Rise adapter * change email for rise * fix circle failed * bump * bump * bump * remove space * Upgrade Rise adapter to 5.0 * added isWrapper param * addes is_wrapper parameter to documentation * added is_wrapper to test * removed isWrapper * Rise Bid Adapter: support Coppa param (prebid#24) * MinuteMedia Bid Adapter: support Coppa param (prebid#25) * Revert "MinuteMedia Bid Adapter: support Coppa param (prebid#25)" (prebid#26) This reverts commit 66c4e7b. * bump * update coppa fetch * setting coppa param update * update Coppa tests * update test naming * Rise Bid Adapter: support plcmt and sua (prebid#27) * update minuteMediaBidAdapter - support missing params (prebid#29) * add currency param to bid object and tests * update getFloor function and tests * adding test to currency param * adding doc & currency bidfloor support & update tests * update currency test * remove default test --------- Co-authored-by: Noam Tzuberi <[email protected]> Co-authored-by: noamtzu <[email protected]> Co-authored-by: Noam Tzuberi <[email protected]> Co-authored-by: Laslo Chechur <[email protected]> Co-authored-by: OronW <[email protected]> Co-authored-by: lasloche <[email protected]> Co-authored-by: inna <[email protected]> Co-authored-by: YakirLavi <[email protected]>

* Add detail to error executing handler * Add test case for including eventString

* Edited viantOrtbBidAdapter bidder endpoint url. * Update viantOrtbBidAdapter.js * Update viantOrtbBidAdapter.js

* Add new window features to HB request * fixup! Add new window features to HB request

* SparteoBidAdapter: handle vastUrl for video context * Add: video tests

* Yandex Bid Adapter: add support for topicsFpdModule * add test

* Initial implementation of kulturemedia bid adapter * Changing outstream to instream * Enriching md file with test examples * Changing nId to networkId * Cleaning up md file * Submitting rebranded dxkultureBidAdapter * dxkultureBidAdapter - Improve UserSyncs * Include gdpr/usp params in iframe usersync url * Add gdpr/usp data to iframe usync urls * Cleaning up testing html file * Adding outstream support * Updating exchange endpoint * Resolve requests test * Resolving iframe/pixel priority when iframeEnabled/pixelEnabled * Improving userSync filtering condition * Prioritize iframe user syncing --------- Co-authored-by: Danijel Predarski <[email protected]> Co-authored-by: dani-nova <[email protected]> Co-authored-by: Slavisa Petkovic <[email protected]> Co-authored-by: Slavisa Petkovic <[email protected]>

Added a test case for native ads

…rebid#10849) * initial commit * adapted buildRequests function * refinement pfilter and bcat * refinement * adapted tests for isBidRequestValid,buildRequests * adaptations for test * finished building stvBidAdapter.js * finished: ran tests, coverage 99% * update: rename w->srw, h->srh * adapt stvBidAdapter.md * remove dspx from stv adapters * some changes (missing: getUserSyncs, but is the same as in radsBidAdapter) * added checks in getUserSyncs; ran tests * added schain support (94.8% coverage) * correct schain encoding * added serializeUids and adapted serializeSChain --------- Co-authored-by: theo_ <theo_@IDEA3>

* update lc version * fix typo

* Update skipRate handling in priceFloors.js and add unit tests for the changes. * Update wording on tests and remove unecessary spread.

…de tracker for pubmatic 3.Skipped adding pubmatic bid in logger (prebid#10897)

…erSyncs (prebid#10800)

…#10899)

* Removed linting issues * Fixed merge issues. * Bugfix on storageTool. * Adnuntius Bid Adapter: bugfix handling ad response Handle no voidAuIds better. --------- Co-authored-by: Mikael Lundin <[email protected]> Co-authored-by: Mikael Lundin <[email protected]>

…sampling and improve transparency (prebid#10792) * track billing events and modify sampling pattern * review updates

* feat: pangle multi format * feat: multi format

* BeOp Bid Adapter: Add eids support (#14) * Fix tests

* PE-87: Implement Prebid Adapter (#1) * PE-87: implement BT Bid Adapter * PE-87: rework adapter to use ortbConverter lib, make requested changes * PE-87: update imports * PE-110: Add user sync logic to the Prebid Adapter (#3) * PE-110: add user sync logic * PE-110: update userSync url * PE-110: check if iframe is enabled before setting params * PE-111: BT Prebid Adapter can request AA ads or regular ads (#2) * PE-120: Send Prebid Bidder info to BT Server (#4) * PE-120: add btBidderCode to the bid object * PE-120: use single quotes for logs string * PE-123: Add More Metadata in site.ext.blockthrough (#5) * PE-123: send additional meta data * PE-123: send auctionID under imp.ext.prebid.blockthrough * PE-123: use ortb2 config to set site.ext params * PE-123: sent auctionId in ext.prebid.blockthrough.auctionID * PE-123: update logs for bidderConfig setup * PE-000: check if blockthrough is defined (#6) * PE-87: remove BT specific logic (#7) * Implement Blockthrough Prebid Adapter * PE-87: Implement Prebid Adapter - misc fixes (#9) * PE-87: rename test file, add bidder config * PE-87: increase ttl * PE-000: fix test * BP-74: Change the way we enable debug (#10) * BP-79: Send GPID as a part of `imp[].ext` (#11) * BP-79: send gpid in imp.ext * BP-79: add optional operator * BP-90: Update Cookie Sync Logic (#12) * BP-90: pass bidder to cookie sync * BP-90: update sync logic, fix typo * BP-90: use const for syncs variable * BP-55: Re-add endpoint URLs (#13) * BP-91: Add prebid JS version to auction request (#14)

* create setupadBidAdapter * add setupadBidAdapter * update setupadBidAdapter * update metrics collection * update analytics collection * update getUserSyncs * add setupadAnalyticsAdapter.js * test setupadAnalyticsAdapter * remove test: 1 * add GVLID && bug fixes && test updates * remove setupadAnalyticsAdapter * add userID module handling * add GVLID && bug fixes && test updates * remove setupadAnalyticsAdapter * add userID module handling * clean up && seat bugfix * clean up logs * add userID module handling * update md && clean up * Send setupad only on bidRequested * Fix bidResponse and bidWon responses * Improve bidResponse and bidWon logic * Revert changes to specific files * Remove test parameter * Fix multiple bidResponse and bidTimeout calls to getPixelUrl * eslint errors fixes(brackets added) * Add extra checks for events * Fix BIDDER_CODE const * update reporting endpoint * update setupadBidAdapter_spec.js REPORT_ENDPOINT * update readme * Revert "Merge branch 'prebid:master' into setupad-adapter" This reverts commit 1c14dbe, reversing changes made to 7fe9ea5. * Revert "Revert "Merge branch 'prebid:master' into setupad-adapter"" This reverts commit a34e3e4. * # This is a combination of 20 commits. # This is the 1st commit message: add setupadBidAdapter # This is the commit message #2: update setupadBidAdapter # This is the commit message #3: update metrics collection # This is the commit message #4: update analytics collection # This is the commit message #5: update getUserSyncs # This is the commit message #6: add setupadAnalyticsAdapter.js # This is the commit message #7: test setupadAnalyticsAdapter # This is the commit message #8: remove test: 1 # This is the commit message #9: add GVLID && bug fixes && test updates # This is the commit message #10: remove setupadAnalyticsAdapter # This is the commit message #11: add userID module handling # This is the commit message #12: clean up && seat bugfix # This is the commit message #13: add userID module handling # This is the commit message #14: add GVLID && bug fixes && test updates # This is the commit message #15: remove setupadAnalyticsAdapter # This is the commit message prebid#16: add userID module handling # This is the commit message prebid#17: clean up logs # This is the commit message prebid#18: update md && clean up # This is the commit message prebid#19: Send setupad only on bidRequested # This is the commit message prebid#20: Fix bidResponse and bidWon responses * # This is a combination of 22 commits.tree 8abae7e6dffc9a21ad11770713ba485fc610028a parent cecfce3 author pavel <[email protected]> 1706627437 +0200 committer pavel <[email protected]> 1706627437 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E= =oJtZ -----END PGP SIGNATURE----- bugfixes # This is the commit message prebid#22: Remove test parameter * # This is a combination of 26 commits. parent cecfce3 author pavel <[email protected]> 1706627437 +0200 committer pavel <[email protected]> 1706627437 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E= =oJtZ -----END PGP SIGNATURE----- bugfixes # This is the commit message prebid#22: Remove test parameter # This is the commit message prebid#23: Fix multiple bidResponse and bidTimeout calls to getPixelUrl # This is the commit message prebid#25: eslint errors fixes(brackets added) # This is the commit message prebid#26: Add extra checks for events * parent 75178b9 author pavel <[email protected]> 1706627694 +0200 committer pavel <[email protected]> 1706627694 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5Em4ACgkQFABtd4pC s/BBUQ/+NXyHoxPM185YJLG9M1ySC/5vTT9W5mfwQ93cVDLCeuGnpsnmi4S21NuQ b7gSeokFjwztvVOUmh/xqMp4lTsvL53TUd00b1k4KGVSqgcF00Foit5g8fOGLYsI DAoqphYV6MWjpAun+II+ELY8QUkHR1cjTc7PEGtmf+8RnptGVdyJ6C9Ab8u9TQTY Apj5Srhfo3Tl8S+WScOxwwB/uqEJR4fhIrJyzFzdLDEb2olSPyrQUs87vQXlhEnK buPEg2F5JsRH6sw11Xp3TFNSZGxNnBSlTh9dixou5md4yRCv5a2TMef667N0BVDp lGgc7mCrRKXyqzphmmeHudiscEGFjtUPObXoHutSVw22wdARFCTpNFKBLLFn4v8o Zv1OvFdNprvHsoeW0HVlZdU7OKnDTRrko6DHk2AahxojjvAFEWuDsGYZNjhdQwRR lK1zm+SFQnKI0Eojd+f84fvKod9geGs640jyH/x5R4eYm4yjZb8SkRtd3cca88wS OuGq9LIkbU428b46l7VnDwudldTXPUU8eKfUtFRjdGtIWH9I3tK6TsRoCfTcXkv0 smxYiiU1XHjAkkPFWQWEeFdfZ071snFKVWouU0AoKiq+PdRoS8+3AJqIQUjlA2sH AybnSkv9KxY/Rs1bnvMubsQm1GF66qVrbxBU6FILBv1JZYwj4yA= =Gbog -----END PGP SIGNATURE----- bugfixes update setupadBidAdapter_spec.js REPORT_ENDPOINT update readme Revert "Merge branch 'prebid:master' into setupad-adapter" This reverts commit 1c14dbe, reversing changes made to 7fe9ea5. Revert "Revert "Merge branch 'prebid:master' into setupad-adapter"" This reverts commit a34e3e4. * change double quote to single quote --------- Co-authored-by: pavel <[email protected]> Co-authored-by: Elgars Grodnis <[email protected]> * bugfix setupadBidAdapter remove getAdEl, spelling correction * add onBidWon event onBidWon event handling moved from custom to native onBidWon method * minor bugfixes && remove funk getSiteObj && getDeviceObj --------- Co-authored-by: pavel <[email protected]> Co-authored-by: Elgars Grodnis <[email protected]>

) * collect EIDs for bid request * add ad slot positioning to payload * RPO-2012: Update local storage name-spacing for c_uid (#8) * Updates c_uid namespacing to be more specific for concert * fixes unit tests * remove console.log * RPO-2012: Add check for shared id (#9) * Adds check for sharedId * Updates cookie name * remove trailing comma * [RPO-3152] Enable Support for GPP Consent (#12) * Adds gpp consent integration to concert bid adapter * Update tests to check for gpp consent string param * removes user sync endpoint and tests * updates comment * cleans up consentAllowsPpid function * comment fix * rename variables for clarity * fixes conditional logic for consent allows function (#13) * [RPO-3262] Update getUid function to check for pubcid and sharedid (#14) * Update getUid function to check for pubcid and sharedid * updates adapter version * [RPO-3405] Add browserLanguage to request meta object * ConcertBidAdapter: Add TDID (prebid#20) * Add tdid to meta object * Fix null handling and add tests * Concert Bid Adapter: Add dealId Property to Bid Responses (prebid#22) * adds dealid property to bid responses * updates tests * use first bid for tests * adds dealid at the correct level --------- Co-authored-by: antoin <[email protected]> Co-authored-by: Antoin <[email protected]> Co-authored-by: Sam Ghitelman <[email protected]> Co-authored-by: Sam Ghitelman <[email protected]>

@garciapuig

…rebid#11775) * Azerion Edge RTD Module: Initial release ### Type of change [x] Feature: New RTD Submodule ### Description of change Adds new Azerion Edge RTD module. Maintainer: azerion.com Contact: @garciapuig @mserrate @gguridi * Azerion Edge RTD Module: Initial release. Typo * AzerionEdge RTD Module: Documentation: Required parameters Type of change: Documentation/Feature Description of change: Specifying new required parameters on documentation. Updating examples. * AzerionEdge RTD Module: Compatible with GDPR/USP Privacy Modules (#14) - Added GDPR validation. - We validate against ImproveDigital vendor ID consent and several purposes. - We don't load edge script, nor process the existing data, if consent wasn't given. - Adding support for USP consent. * AzerionEdgeRTDModule: Passing the consent to the script execution (prebid#17) Adding GVL ID to the module configuration Passing the consent to the script execution instead of handling it in prebid (prebid#16) --------- Co-authored-by: Gorka Guridi <[email protected]> --------- Co-authored-by: Gorka Guridi <[email protected]>

johnwier requested review from pycnvr and AaronColbyPrice November 29, 2023 17:51

Adagio Bid Adapter: add GPID support (prebid#10775)

b154fc1

dgirardi and others added 13 commits November 29, 2023 18:00

Core: add option to turn off Sec-Browsing-Topics header (prebid#10776)

73fb8d3

Missena Bid Adapter: add capping support (prebid#10746)

d70097e

* Missena Bid Adapter: add capping support * Switch to safeJSONParse * Update tests to cover capping

GC-157 Boune request when the PID is missing (prebid#10774)

7dd09d8

Generic analytics: fix spurious warning messages (prebid#10739)

a8fedc6

Prebid 8.26.0 release

5202784

Increment version to 8.27.0-pre

ec42b13

identityLinkIdSystem - liveramp - bug fix setting tcf consent string …

16133c5

…in 3p call (prebid#10778)

Add GVLID to vox adapter (prebid#10784)

faec1bb

LiveIntent UserId module: Add support for sovrn id (prebid#10783)

fe2f35e

* Add EID translation for sovrn * Review comments: fix test

pycnvr requested changes Dec 1, 2023

View reviewed changes

bhainesnexxen and others added 12 commits December 1, 2023 12:26

Replace openx.com with openx.net (prebid#10786)

4f3826a

Core: Add eventString to error executing handler message (prebid#10797)

55ba111

* Add detail to error executing handler * Add test case for including eventString

Adagio Bid Adapter: remove useless adrequest fields (prebid#10794)

f818b8f

VIS.X: add response time tracking on bidWon event (prebid#10772)

9a65d49

ViantOrtb Bid Adapter : update endpoint url (prebid#10801)

264efa7

* Edited viantOrtbBidAdapter bidder endpoint url. * Update viantOrtbBidAdapter.js * Update viantOrtbBidAdapter.js

Teads Bid Adapter: add new window features to request (prebid#10796)

bf909ea

* Add new window features to HB request * fixup! Add new window features to HB request

Sparteo Bid Adapter : handle vastUrl for video context (prebid#10805)

0de4a09

* SparteoBidAdapter: handle vastUrl for video context * Add: video tests

prebidjs-release and others added 20 commits December 28, 2023 20:52

Increment version to 8.30.0-pre

46784ab

Yandex Bid Adapter: add support for topicsFpdModule (prebid#10875)

cc49968

* Yandex Bid Adapter: add support for topicsFpdModule * add test

Yandex Bid Adapter: add jsdoc (prebid#10884)

ff27673

Mygaru Id System: Initial release (prebid#10848)

04a7659

Update viantOrtbBidAdapter_spec.js (prebid#10888)

ed05478

Added a test case for native ads

Missena Bid Adapter: allow per page capping (prebid#10863)

185e97f

LiveIntent ID Module: Update live-connect version (prebid#10894)

49904a0

* update lc version * fix typo

Do not require API for video requests (prebid#10895)

136f0bb

Price Floors: Failure to Account for 'data.skipRate' (prebid#10872)

7a09d81

* Update skipRate handling in priceFloors.js and add unit tests for the changes. * Update wording on tests and remove unecessary spread.

Prebid 8.30.0 release

aa21bfd

Increment version to 8.31.0-pre

714acd3

1.Added safechecks for s2s metadapter case 2.Skipped firing client si…

866be6e

…de tracker for pubmatic 3.Skipped adding pubmatic bid in logger (prebid#10897)

Discovery Bid Adapter: update buyerId, add ssppid & pmguid, add getUs…

60e7e96

…erSyncs (prebid#10800)

ID5 User Id module - pass gpp string and sid in getId request (prebid…

cdbe68c

…#10899)

GreenbidsAnalyticsAdapter and GreenbidsRtdProvider: Rework greenbids …

3e6b546

…sampling and improve transparency (prebid#10792) * track billing events and modify sampling pattern * review updates

Core: add eslint-plugin-jsdoc (prebid#10893)

d390f6c

Pangle Bid Adapter : add multi format support (prebid#10909)

759c52d

* feat: pangle multi format * feat: multi format

johnwier force-pushed the cnvr_useOrtbConverter branch from 993891b to 592c8dc Compare January 8, 2024 19:41

Conversant adapter: use ortbConverter to handle requests and responses

2379853

johnwier force-pushed the cnvr_useOrtbConverter branch from 592c8dc to 2379853 Compare January 8, 2024 19:42

johnwier closed this Jan 8, 2024

johnwier pushed a commit that referenced this pull request Feb 20, 2024

BeOp Bid Adapter: add eids support (prebid#11025)

7f0732f

* BeOp Bid Adapter: Add eids support (#14) * Fix tests

johnwier deleted the cnvr_useOrtbConverter branch May 21, 2024 18:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conversant adapter: use ortbConverter to handle requests and responses #14

Conversant adapter: use ortbConverter to handle requests and responses #14

johnwier commented Nov 29, 2023

AaronColbyPrice commented Nov 29, 2023

pycnvr Nov 30, 2023

johnwier Dec 4, 2023

pycnvr Nov 30, 2023

pycnvr Nov 30, 2023

johnwier Dec 4, 2023

pycnvr Nov 30, 2023

pycnvr Nov 30, 2023

pycnvr Dec 1, 2023

johnwier Dec 4, 2023

pycnvr Dec 1, 2023

johnwier Dec 4, 2023

pycnvr Dec 4, 2023 •

edited

Loading

johnwier Dec 4, 2023

pycnvr Dec 1, 2023

johnwier Dec 4, 2023

pycnvr Dec 1, 2023

Conversant adapter: use ortbConverter to handle requests and responses #14

Conversant adapter: use ortbConverter to handle requests and responses #14

Conversation

johnwier commented Nov 29, 2023

Type of change

Description of change

Other information

AaronColbyPrice commented Nov 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pycnvr Dec 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pycnvr Dec 4, 2023 •

edited

Loading